Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance offline script and documentation #5447

Merged
merged 1 commit into from
May 3, 2024

Conversation

claudio4j
Copy link
Contributor

  • Enhance the offline script
    . Use quarkus:go-offline.
    . build a minimum project to resolve dependencies not resolved with the previous script.
    . The user can download only the script to run it.
  • Enhance documentation

Release Note

Enhance the offline script and documentation.

- Enhance the offline script to use quarkus:go-offline and to build a minimum project
  to resolve dependencies not resolved with the previous script
- Enhance documentation
@claudio4j claudio4j requested a review from squakez May 2, 2024 13:56
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original goal of this guideline was to provide a general idea about how any user could start its own strategy of creating an offliner without entering too much into low level details that can change for each installation. With the previous work we were telling the final user where to find all dependencies (the catalog) and a simple loop example that they could use as a reference for their own development.

I see that with this one you're moving a step further trying to mimic what the operator is doing and I am not sure we'll be able to maintain in the long run. The main concern is that this is strongly catered to Quarkus runtime and it creates adhoc pom.xml that may change in the future and would require a continuous effort from the community to maintain it.

That's my opinion, feel free to go ahead with the work if you think it's really worth.

@claudio4j
Copy link
Contributor Author

As the disconnected mode is a corner case, it's difficult to gather feedback. Sure, maintaining the pom embedded generation is going to be difficult. As documented, this is a best effort. Thanks for your review.

@claudio4j claudio4j merged commit 6fee6d6 into apache:main May 3, 2024
12 checks passed
@claudio4j claudio4j deleted the upstream/main_offline branch May 3, 2024 09:10
claudio4j added a commit to claudio4j/camel-k that referenced this pull request May 3, 2024
- Enhance the offline script to use quarkus:go-offline and to build a minimum project
  to resolve dependencies not resolved with the previous script
- Enhance documentation

(cherry picked from commit 6fee6d6)
claudio4j added a commit that referenced this pull request May 3, 2024
- Enhance the offline script to use quarkus:go-offline and to build a minimum project
  to resolve dependencies not resolved with the previous script
- Enhance documentation

(cherry picked from commit 6fee6d6)
squakez pushed a commit to jboss-fuse/camel-k that referenced this pull request May 3, 2024
- Enhance the offline script to use quarkus:go-offline and to build a minimum project
  to resolve dependencies not resolved with the previous script
- Enhance documentation

(cherry picked from commit 6fee6d6)

(cherry picked from commit apache/camel-k@48cf1b3d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants