Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.3.x] fix(core): Remove status.Image update post publish #5599

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[Backport 2.3.x] fix(core): Remove status.Image update post publish #5599

merged 1 commit into from
Jun 6, 2024

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Jun 6, 2024 •
edited
Loading

Backport of #5600

Release Note

fix(core): Remove status.Image update post publish

squakez
squakez approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd create a follow up issue in order to create a unit test for the build controller if it cannot be done in this PR already.

@squakez squakez linked an issue Jun 6, 2024 that may be closed by this pull request
ImagePullBackOff Error for pod build strategy and s2i publish strategy #5595
Closed
@squakez squakez added the trigger native test Use this label in PR when you want to trigger Quarkus Native tests label Jun 6, 2024
@gansheer gansheer changed the title fix(core): Remove status.Image update post publish [Backport 2.3.x] fix(core): Remove status.Image update post publish Jun 6, 2024
@gansheer gansheer marked this pull request as ready for review June 6, 2024 14:19
@gansheer gansheer merged commit af9daba into apache:release-2.3.x Jun 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
trigger native test Use this label in PR when you want to trigger Quarkus Native tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImagePullBackOff Error for pod build strategy and s2i publish strategy
2 participants
@gansheer @squakez