add itests for camel-cxfrs-kafka-connector #996 #1099
Conversation
| } | ||
|
|
||
|
|
||
| public abstract static class AbstractTestProcessor implements Processor { |
There was a problem hiding this comment.
I'd probably look into moving these processing code to a separate Camel-based test service (in a similar way to the one we have in the syslog tests, for example). That way, we can potentially reuse more test code when adding new scenarios to this.
| * A simple test case that checks whether the CXF RS Consumer Endpoint produces the expected number of | ||
| * messages | ||
| */ | ||
| public class CamelSourceCXFRSITCase extends AbstractKafkaTest { |
There was a problem hiding this comment.
I'd try using the CamelSourceTestSupport class as the base class for the tests, as it abstracts away some of the setup, test logic and tear down complexity.
|
|
||
| protected static final int PORT = NetworkUtils.getFreePort("localhost"); | ||
| protected static final String CXT = PORT + "/CxfRsConsumerTest"; | ||
| protected static final String CXF_RS_ENDPOINT_ADDRESS = "http://localhost:" + CXT + "/rest"; |
There was a problem hiding this comment.
I'd use the NetworkUtils.getLocalHostname() method to avoid problems when running these on misconfigured hosts (we did saw some problems with false positives on Github actions due to this).
There was a problem hiding this comment.
Thanks @orpiske for the feedbacks! I will revise accordingly.
… cxfrs-itests-merge
(cherry picked from commit 94929f3)
No description provided.