-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMQP JMS source kamelet #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be ok, but we need to use the same naming convention.
Also, run mvn clean install, so it will be added to catalog.
And after that have a look at script/generator to generate docs and script/validate to validate.
@oscerd one problem that I foresee with this one is that it does not have a free icon available. If we enforce the MUST have More especifically: the group developing the AMQP 1.0 protocol, does not seem to make available a free icon to use. I'll check around with some contacts, but it may not be guaranteed we'll have one. |
You can use any icon related to messaging, it shouldn't be a logo or something related to amqp. So even a message icon is fine. |
That helps. Let's use the QPid one. Thanks! |
cb08808
to
d14f2c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.