-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mail sink Kamelet #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sink yaml in kamelets seems to be different from the one copied in the library. Also i would probably use the same convention of having both ce headers and not supported
Looks good overall |
3ce2d74
to
6366fbe
Compare
@oscerd thanks fixed the kamelet sources. could you please approve the workflow run once more? |
Done. Thanks. |
6366fbe
to
6cfe988
Compare
@oscerd previous workflow run was hanging due to issue with YAKS versioning. Could you please approve once more 🙏 this hanging workflow can be cancelled https://github.com/apache/camel-kamelets/runs/4433396398?check_suite_focus=true |
6cfe988
to
df03ca5
Compare
@oscerd forgot username and password as mandatory Kamelet properties. sorry for the trial end error. I think we are close to getting this test running green 🤞 |
No worries! Thanks a lot for your time! |
df03ca5
to
927164e
Compare
@oscerd please one more round of approval 🙏 |
927164e
to
74a524c
Compare
@oscerd ha, found a last issue. the test requires both timer-source and mail-sink Kamelet to be available in the namespace. Please approve once more. |
Wohooo! SUCCESS! @oscerd many thanks for staying with me |
Happy to help |
No description provided.