-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Generate kamelets pages using Antora (main) #630
Conversation
dcd5ecc
to
23fabe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to take into account also the generator.go script. cc @nicolaferraro
Yes, at the moment both original and new versions of the kamelets pages are shown for easier comparison. |
Yes, the generator puts images into assets/images/kamelets, so I think this line needs to be changed: camel-kamelets/script/generator/generator.go Line 360 in 381fb8b
|
I’ll try to finish this up…. the new stuff has Antora extract the image from the yml, IIRC the generator is not needed at all.
… On Dec 21, 2021, at 2:01 AM, Nicola Ferraro ***@***.***> wrote:
Yes, at the moment both original and new versions of the kamelets pages are shown for easier comparison. One difference is that I changed how the "required" status of a property is shown to match the other tables I've worked on: instead of a star after the name, the description starts with at bold "Required".
Yes, the generator puts images into assets/images/kamelets, so I think this line needs to be changed: https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360 <https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360>
—
Reply to this email directly, view it on GitHub <#630 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXRSSQE62GRZOBIYXOLUSBF7RANCNFSM5KCPNZUQ>.
You are receiving this because you authored the thread.
|
23fabe4
to
f82a195
Compare
This is ready to review.... would be nice to get it in before there are a lot more new kamelets :-) |
The generator script only generates the nav file now, but it's still loading the entire yaml into a model because I can't figure out how the name gets into the model or how to get it on it's own. |
f82a195
to
14cef5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this won't break the projects using this stuff. I'll give a try to the PR locally and check.
LGTM at first sight btw |
14cef5f
to
c2754d1
Compare
There was a problem with finding the images... not sure how my local builds worked... should be fixed now. |
I think this PR will be OK but there's a bug in @djencks/asciidoctor-antora-indexer that prevents more than one set of components being generated properly in a full build. I'll let you know when it's fixed... |
Ok, let's wait. |
c2754d1
to
0b1e09b
Compare
0b1e09b
to
a5962ee
Compare
a5962ee
to
33b94cd
Compare
This is all fixed (all 3 branches) and the preview is at https://pr-735--camel.netlify.app/ |
Here https://pr-735--camel.netlify.app/camel-kamelets/latest/ I'm getting This file exists solely to defeat the limitations of the link checker, that is unaware of the .htaccess redirect from this page to the latest released version. If you see this, you are not viewing the site through httpd or there is something wrong with the .htaccess file: in the latter case please let the camel developers know. |
Netlify doesn’t understand httpd redirects, as hinted by the second line.
Try https://pr-735--camel.netlify.app/camel-kamelets/0.6.x/index.html
… On Dec 22, 2021, at 10:26 PM, Andrea Cosentino ***@***.***> wrote:
Here
https://pr-735--camel.netlify.app/camel-kamelets/latest/ <https://pr-735--camel.netlify.app/camel-kamelets/latest/>
I'm getting
This file exists solely to defeat the limitations of the link checker, that is unaware of the .htaccess redirect from this page to the latest released version.
If you see this, you are not viewing the site through httpd or there is something wrong with the .htaccess file: in the latter case please let the camel developers know.
—
Reply to this email directly, view it on GitHub <#630 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXVV5GIZYU24FIHZQXTUSK6H7ANCNFSM5KCPNZUQ>.
You are receiving this because you authored the thread.
|
LGTM. |
Thanks |
Is 'LGTM' the same as approval? I don't know what to do with the "changes requested" review since the code reviewed is gone. |
yeah, I forgot to approve. |
See apache/camel-website#720