-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(salesforce-sink): Add, update, and delete salesforce sink #862
Conversation
Pending: add secrets to Github and make the secrets load properly on the tests. |
@christophd can you help me with the secrets? |
Disabled tests directly to salesforce api to prevent problems if the api is down. |
55659b6
to
d1f0d7b
Compare
The failed test is not related to this PR... |
Should I maybe rebase? Or is it flaky tests and will be the same? |
It's not failing on other PRs. |
Let's try to rebase. |
Also, improved documentation on all salesforce sink
d1f0d7b
to
0b973b4
Compare
after the rebase the test is green, YAY! this Kafka test has been flaky before (~50% failing) but I think I have fixed some issues with it. as @oscerd has mentioned the test is stable on other PRs. So lets's keep an eye on that one as it may still be flaky (maybe ~10%). |
No description provided.