Ref #590 Add Bundle-Name and Bundle-SymbolicName to wrapped bundles #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essobedo
approved these changes
Jan 29, 2025
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jan 30, 2025
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
...aven-plugin/src/main/java/org/apache/camel/karaf/feature/maven/EnsureWrapBundleNameMojo.java
Outdated
Show resolved
Hide resolved
|
It looks like it causes a regression in the IT of camel-fastjson |
|
It looks good to me. I just wonder for the "existing" features: can we re-run the plugin or is it coupled with an update ? |
The plugin is executed at build time, so it's coupled to an update of the feature repository |
f2par0
added a commit
to Talend/camel-karaf
that referenced
this pull request
Jan 30, 2025
…dles (apache#591) Motivation Very long names in karaf console when listing bundles by names or symbolic names Modifications: Add Bundle-Name= and Bundle-SymbolicName= to the wrapped bundles
f2par0
added a commit
to Talend/camel-karaf
that referenced
this pull request
Jan 30, 2025
…dles (apache#591) Motivation Very long names in karaf console when listing bundles by names or symbolic names Modifications: Add Bundle-Name= and Bundle-SymbolicName= to the wrapped bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590
Motivation
Very long names in karaf console when listing bundles by names or symbolic names
Modifications:
Add Bundle-Name= and Bundle-SymbolicName= to the wrapped bundles