Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some openapi-java array types cannot be configured #5559

Closed
jamesnetherton opened this issue Nov 27, 2023 · 5 comments
Closed

Some openapi-java array types cannot be configured #5559

jamesnetherton opened this issue Nov 27, 2023 · 5 comments
Assignees
@zhfeng
Labels
area/openapi-java bug Something isn't working
Milestone
3.7.0

Comments

@jamesnetherton
Copy link
Contributor

Bug description

https://issues.apache.org/jira/browse/CAMEL-20156
@jamesnetherton jamesnetherton added the bug Something isn't working label Nov 27, 2023
@zhfeng
Copy link
Contributor

zhfeng commented Nov 29, 2023

@jamesnetherton is there any reproducer?

It looks like that we can use Schema::cast method

https://github.com/swagger-api/swagger-core/blob/master/modules/swagger-models/src/main/java/io/swagger/v3/oas/models/media/Schema.java#L854-L856

@jamesnetherton
Copy link
Contributor Author

jamesnetherton commented Nov 29, 2023 •
edited
Loading

@jamesnetherton is there any reproducer?

https://github.com/apache/camel-quarkus/blob/main/integration-tests/openapi-java/src/main/java/org/apache/camel/quarkus/component/openapijava/it/OpenApiRoutes.java#L200-L230

Not sure if the allowableValues I used for those types is 100% correct. I could not verify it due to the bug.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 29, 2023

OK, I will check them when I find a fix in camel.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 30, 2023

Hi @jamesnetherton ,

I open apache/camel#12269 and can you take a look?

@zhfeng zhfeng self-assigned this Nov 30, 2023
@zhfeng
Copy link
Contributor

zhfeng commented Dec 4, 2023

There is still https://issues.apache.org/jira/browse/CAMEL-20181 for making sure support for 3.0 and 3.1

zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Dec 5, 2023
@zhfeng
Fix apache#5559 to add tests for array with type of boolean, byte, bi…
df2e3be 
…nary date, datetime and password
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Dec 5, 2023
@zhfeng
Fix apache#5559 to add tests for array with type of byte, binary date…
90e0045 
…, datetime and password
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Dec 5, 2023
@zhfeng
Fix apache#5559 to add tests for array with type of byte, binary, dat…
ab154e4 
…e, datetime and password
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Dec 7, 2023
@zhfeng
Fix apache#5559 to add tests for array with type of byte, binary, dat…
efb09f6 
…e, datetime and password
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Dec 7, 2023
@zhfeng
Fix apache#5559 to add tests for array with type of byte, binary, dat…
d73a1ff 
…e, datetime and password
jamesnetherton pushed a commit that referenced this issue Dec 7, 2023
@zhfeng @jamesnetherton
Fix #5559 to add tests for array with type of byte, binary, date, dat…
0198067 
…etime and password
JiriOndrusek pushed a commit that referenced this issue Dec 11, 2023
@zhfeng @JiriOndrusek
Fix #5559 to add tests for array with type of byte, binary, date, dat…
65c5c4d 
…etime and password
JiriOndrusek pushed a commit that referenced this issue Dec 12, 2023
@zhfeng @JiriOndrusek
Fix #5559 to add tests for array with type of byte, binary, date, dat…
3677701 
…etime and password
JiriOndrusek pushed a commit that referenced this issue Dec 12, 2023
@zhfeng @JiriOndrusek
Fix #5559 to add tests for array with type of byte, binary, date, dat…
0907158 
…etime and password
JiriOndrusek pushed a commit to JiriOndrusek/camel-quarkus that referenced this issue Dec 12, 2023
@zhfeng @JiriOndrusek
Fix apache#5559 to add tests for array with type of byte, binary, dat…
802c285 
…e, datetime and password
jamesnetherton pushed a commit to JiriOndrusek/camel-quarkus that referenced this issue Jan 2, 2024
@zhfeng @jamesnetherton
Fix apache#5559 to add tests for array with type of byte, binary, dat…
e3d7a51 
…e, datetime and password
@github-actions github-actions bot added this to the 3.7.0 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhfeng zhfeng

Labels
area/openapi-java bug Something isn't working
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@zhfeng @jamesnetherton