Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Quarkus to 3.4.0.CR1 #5270

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

jamesnetherton
Copy link
Contributor

I am expecting some test failures. Lets see how it goes...

@jamesnetherton
Copy link
Contributor Author

For reasons that I don't quite understand, I have to add quarkus-virtual-threads explicitly to the knative extension. Some more chat about it here:

https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/3.2E4.2E0.2ECR1.20extension-descriptor.20build.20error

@aldettinger
Copy link
Contributor

Shouldn't be that bad anyway: knative is more an internal thing if I remember well ?
Also not sure about the why... maybe using provided scope could workaround and be less intrusive, not sure.

@jamesnetherton
Copy link
Contributor Author

maybe using provided scope could workaround and be less intrusive

It's a transitive of quarkus-vertx-http, so I think that would override the original compile scope, which is probably not what we want.

The weird thing is that the error only occurs when the build is run from the project root. And not when run directly from the knative extension directory.

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok clearer, a difference between top project and sub module could be the parent pom interpolation that would bring something in the mix... not sure it's a good track.

Given that knative is not meant for direct usage (from what I remind), the workaround might not be be that bad.

@ozangunalp
Copy link

@jamesnetherton I think this is because of the dependencyManagement block in knative/runtime pom: https://github.com/apache/camel-quarkus/pull/5270/files#diff-5c3184557ba89a2880c09703d5299342d7bd21b23fa080a3d93e2a23ad861ef5R38-R48

But I don't know if there is a specific reason for that import.

@jamesnetherton jamesnetherton merged commit 8393735 into apache:main Sep 7, 2023
20 checks passed
@jamesnetherton jamesnetherton deleted the quarkus-3.4.0.CR1 branch September 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants