Add multipart configuration options to servlet extension #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
reviewed
Sep 21, 2023
...rvlet/runtime/src/main/java/org/apache/camel/quarkus/servlet/runtime/CamelServletConfig.java
Outdated
Show resolved
Hide resolved
ppalaga
reviewed
Sep 21, 2023
...sts/servlet/src/main/java/org/apache/camel/quarkus/component/servlet/MultiPartProcessor.java
Outdated
Show resolved
Hide resolved
oscerd
approved these changes
Sep 21, 2023
jamesnetherton
force-pushed
the
servlet-multipart-config
branch
from
1dd9d6f
to
da303b4
Compare
|
Latest commit should address review feedback. |
jamesnetherton
force-pushed
the
servlet-multipart-config
branch
from
da303b4
to
0f4f158
Compare
|
Setting the PR to draft as there's an odd issue happening on GitHub CI that I cannot replicate locally. Needs more investigation. |
jamesnetherton
force-pushed
the
servlet-multipart-config
branch
2 times, most recently
from
aa4234e
to
3b17dea
Compare
|
Issues are hopefully resolved now. Turns out I cannot count properly. I had set the byte limit in the config props to less than what I was sending in the valid test scenarios. |
aldettinger
approved these changes
Sep 26, 2023
jamesnetherton
force-pushed
the
servlet-multipart-config
branch
from
3b17dea
to
68f0826
Compare
|
To move this along I opened #5830 to follow up on later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.