Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically register beans with methods annotated with @Handler for reflection #5472

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

shravaniPshetty
Copy link
Contributor

… reflection

@shravaniPshetty
Copy link
Contributor Author

#5378

Moving `HANDLER_ANNOTATION` to static var like `LANGUAGE_ANNOTATION`
@aldettinger
Copy link
Contributor

aldettinger commented Oct 30, 2023

@spatnity Looks promising.

Is there a last @RegisterForReflection annotation left to remove in; integration-tests/foundation-grouped/src/main/java/org/apache/camel/quarkus/component/bean/WithHandlerBean.java ?

@aldettinger
Copy link
Contributor

pr linked to ticket #5378

@jamesnetherton
Copy link
Contributor

Is there a last @handler left to remove

Why would you remove the Handler annotation?

@aldettinger
Copy link
Contributor

Is there a last @handler left to remove

Why would you remove the Handler annotation?

Yes, this is a typo. The question is about removing @RegisterForReflection. Fixing the note.

@jamesnetherton
Copy link
Contributor

@spatnity Looks promising.

Is there a last @RegisterForReflection annotation left to remove in; integration-tests/foundation-grouped/src/main/java/org/apache/camel/quarkus/component/bean/WithHandlerBean.java ?

Anything under integration-tests/foundation-grouped/src is copied from the projects in integration-test-groups/foundation and is never committed. So we just need to remove the annotation in one place.

@jamesnetherton jamesnetherton merged commit 4911819 into apache:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants