Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.x] Update generated files after release #5483

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
"version": "3.2.2-SNAPSHOT",
"version": "3.2.3-SNAPSHOT",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this version does not be changed by the release script automatically since it is a genereated file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. If someone remember what is special about qute, that would be great to share.
Even when setting the next version in Camel Quarkus main branch, there are specific steps for qute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because the maven-release-plugin is configured to only run clean validate as part of preparationGoals & completionGoals.

https://github.com/apache/camel-quarkus/blob/main/pom.xml#L402-L403

That won't be enough to run the component generation bits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like, thanks for pointing 👍 probably running the whole generation at release time would take long.

@jamesnetherton jamesnetherton merged commit 1b87a56 into apache:3.2.x Nov 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants