Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native builder image pull strategy 'missing' to reduce interactions with quay.io #5573

Merged

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@aldettinger
Copy link
Contributor

@jamesnetherton Looks interesting.

So, at each ci build, on first container build the image is pulled only once, and then reused ? And then we have a chance to get a potential container build image update on next build ?

@jamesnetherton
Copy link
Contributor Author

So, at each ci build, on first container build the image is pulled only once, and then reused ?

Yes, correct. Pulled once on each CI node running the native build

And then we have a chance to get a potential container build image update on next build ?

Yeah - CI nodes are ephemeral. So we start with a clean slate on every workflow run.

@jamesnetherton jamesnetherton merged commit 8345838 into apache:main Nov 30, 2023
21 checks passed
@jamesnetherton jamesnetherton deleted the build-image-pull-if-not-present branch November 30, 2023 10:35
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants