Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /bin/bash for release-util sign.sh script #5680

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this also in other repositories. Thanks for noticing and sorry.

@jamesnetherton
Copy link
Contributor Author

I think we should do this also in other repositories. Thanks for noticing and sorry.

It's fine - it likely only matters for awkward folks like me who choose to use Debian *nix variants where /bin/sh != /bin/bash.

@jamesnetherton jamesnetherton merged commit b9d3ed3 into apache:main Jan 25, 2024
3 checks passed
@jamesnetherton jamesnetherton deleted the sign-script-shebang-fix branch January 25, 2024 13:32
@oscerd
Copy link
Contributor

oscerd commented Jan 25, 2024

I think we should do this also in other repositories. Thanks for noticing and sorry.

It's fine - it likely only matters for awkward folks like me who choose to use Debian *nix variants where /bin/sh != /bin/bash.

Well, it's always a use case, so better to fix. I'll take care of projects using the script!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants