-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXF-SOAP: Cover possible regression prior CXF fix causing indefinitive hang #5685
Conversation
e31ebbe
to
85cad4a
Compare
|
||
//non-existing server url is used | ||
requestContext.put(BindingProvider.ENDPOINT_ADDRESS_PROPERTY, | ||
String.format("http://localhost:%d/soapservice/sayHelloWrong", AvailablePortFinder.getNextAvailable())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick - if we don't actually care about the server URL, can we just hard code the port to any value? If so we can remove the dependency on camel-test-junit5
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your point. I used the next available port just to be sure that the port is really not used. Maybe it is not necessary. I'll remove the dependency and hardcode a fixed value
@JiriOndrusek do you mind rebasing on latest I left an optional nitpick comment too. |
85cad4a
to
1cbc957
Compare
PR is rebased and the dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
fixes #5682