CXF-SOAP: Cover possible regression prior CXF fix causing indefinitive hang #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 26, 2024
JiriOndrusek
force-pushed
the
cxf-cover-of-hang
branch
3 times, most recently
from
e31ebbe
to
85cad4a
Compare
jamesnetherton
approved these changes
Feb 1, 2024
|
|
||
| //non-existing server url is used | ||
| requestContext.put(BindingProvider.ENDPOINT_ADDRESS_PROPERTY, | ||
| String.format("http://localhost:%d/soapservice/sayHelloWrong", AvailablePortFinder.getNextAvailable())); |
There was a problem hiding this comment.
Nitpick - if we don't actually care about the server URL, can we just hard code the port to any value? If so we can remove the dependency on camel-test-junit5.
There was a problem hiding this comment.
I understand your point. I used the next available port just to be sure that the port is really not used. Maybe it is not necessary. I'll remove the dependency and hardcode a fixed value
|
@JiriOndrusek do you mind rebasing on latest I left an optional nitpick comment too. |
JiriOndrusek
force-pushed
the
cxf-cover-of-hang
branch
from
85cad4a
to
1cbc957
Compare
|
PR is rebased and the dependency |
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5682