Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinispan test suite integration changes #5719

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

karesti
Copy link
Contributor

@karesti karesti commented Feb 5, 2024

I changed the code to use dev services

for night builds, you might replace dev services image by replacing the https://quarkus.io/guides/infinispan-dev-services#quarkus-infinispan-client-config-group-infinispan-client-build-time-config-dev-service-configuration_quarkus-infinispan-client-devservices-image-name

If you need to override something on the server configuration, you can do it in further versions by using the overriding capabilities
quarkusio/quarkus#38642

@karesti
Copy link
Contributor Author

karesti commented Feb 5, 2024

I don't know who else I should ping here @jamesnetherton @zbendhiba

@karesti karesti marked this pull request as ready for review February 7, 2024 13:48
@karesti karesti changed the title discussion start Infinispan test suite integration changes Feb 7, 2024
@karesti
Copy link
Contributor Author

karesti commented Feb 7, 2024

@jamesnetherton I made tests work locally, but I did not build everything. Let me know what you think about these changes please
cc @zbendhiba

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some missing license headers.

Please also ensure the code formatting Maven mojos are run. If you cd into integration-tests/infinispan-quarkus-client& integration-tests/infinispan and just run the build with mvn clean install -DskipTests you should see that some files got reformatted, so just commit them.

@jamesnetherton
Copy link
Contributor

Seems there's an NPE in native mode:

2024-02-08T10:44:53.1118352Z [INFO] --- failsafe:3.1.2:integration-test (default) @ camel-quarkus-integration-test-infinispan ---
2024-02-08T10:44:53.1154333Z [INFO] Failsafe report directory: /home/runner/work/camel-quarkus/camel-quarkus/integration-tests/infinispan/target/failsafe-reports
2024-02-08T10:44:53.1157027Z [INFO] Using auto detected provider org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
2024-02-08T10:44:53.1229220Z [INFO] 
2024-02-08T10:44:53.1229879Z [INFO] -------------------------------------------------------
2024-02-08T10:44:53.1230504Z [INFO]  T E S T S
2024-02-08T10:44:53.1231079Z [INFO] -------------------------------------------------------
2024-02-08T10:44:53.8698807Z [INFO] Running org.apache.camel.quarkus.component.infinispan.InfinispanIT
2024-02-08T10:44:54.5224358Z Feb 08, 2024 10:44:54 AM org.jboss.logmanager.JBossLoggerFinder getLogger
2024-02-08T10:44:54.5226639Z ERROR: The LogManager accessed before the "java.util.logging.manager" system property was set to "org.jboss.logmanager.LogManager". Results may be unexpected.
2024-02-08T10:44:56.1260574Z Feb 08, 2024 10:44:56 AM io.quarkus.infinispan.client.deployment.devservices.InfinispanDevServiceProcessor runInfinispanDevService
2024-02-08T10:44:56.1262479Z INFO: Starting Dev Service for connection <default>
2024-02-08T10:44:56.1264158Z Feb 08, 2024 10:44:56 AM io.quarkus.infinispan.client.deployment.devservices.InfinispanDevServiceProcessor runInfinispanDevService
2024-02-08T10:44:56.1268339Z INFO: Apply Dev Services config InfinispanDevServicesConfig{enabled=true, port=OptionalInt[31222], shared=true, serviceName='infinispan', imageName=Optional.empty, artifacts=Optional.empty, site=Optional.empty, mcastPort=OptionalInt.empty, tracing=Optional[false], exporterOtlpEndpoint=Optional[http://localhost:4317]}
2024-02-08T10:44:56.1272390Z Feb 08, 2024 10:44:56 AM io.quarkus.infinispan.client.deployment.devservices.InfinispanDevServiceProcessor startContainer
2024-02-08T10:44:56.1274085Z INFO: Config prefix quarkus.infinispan-client.
2024-02-08T10:44:56.3265511Z 2024-02-08 10:44:56,299 INFO  [org.tes.doc.DockerClientProviderStrategy] (build-4) Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first
2024-02-08T10:44:56.5267587Z 2024-02-08 10:44:56,517 INFO  [org.tes.doc.DockerClientProviderStrategy] (build-4) Found Docker environment with local Unix socket (unix:///var/run/docker.sock)
2024-02-08T10:44:56.5270340Z 2024-02-08 10:44:56,518 INFO  [org.tes.DockerClientFactory] (build-4) Docker host IP address is localhost
2024-02-08T10:44:56.6269285Z 2024-02-08 10:44:56,535 INFO  [org.tes.DockerClientFactory] (build-4) Connected to docker: 
2024-02-08T10:44:56.6270813Z   Server Version: 24.0.7
2024-02-08T10:44:56.6271644Z   API Version: 1.43
2024-02-08T10:44:56.6272097Z   Operating System: Ubuntu 22.04.3 LTS
2024-02-08T10:44:56.6272629Z   Total Memory: 15981 MB
2024-02-08T10:44:56.6273472Z 2024-02-08 10:44:56,537 WARN  [org.tes.uti.ResourceReaper] (build-4) 
2024-02-08T10:44:56.6274360Z ********************************************************************************
2024-02-08T10:44:56.6275284Z Ryuk has been disabled. This can cause unexpected behavior in your environment.
2024-02-08T10:44:56.6276170Z ********************************************************************************
2024-02-08T10:44:56.6277274Z 2024-02-08 10:44:56,539 INFO  [org.tes.DockerClientFactory] (build-4) Checking the system...
2024-02-08T10:44:56.6279424Z 2024-02-08 10:44:56,540 INFO  [org.tes.DockerClientFactory] (build-4) ✔︎ Docker server version should be at least 1.6.0
2024-02-08T10:44:56.6281314Z 2024-02-08 10:44:56,556 INFO  [org.tes.ima.PullPolicy] (build-4) Image pull policy will be performed by: DefaultPullPolicy()
2024-02-08T10:44:56.6284563Z 2024-02-08 10:44:56,558 INFO  [org.tes.uti.ImageNameSubstitutor] (build-4) Image name substitution will be performed by: DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')
2024-02-08T10:44:56.6287385Z 2024-02-08 10:44:56,574 INFO  [tc.qua.io/.0] (build-4) Starting an Infinispan container using [quay.io/infinispan/server:14.0]
2024-02-08T10:44:56.6289117Z 2024-02-08 10:44:56,579 INFO  [tc.qua.io/.0] (build-4) Creating container for image: quay.io/infinispan/server:14.0
2024-02-08T10:44:56.8273274Z 2024-02-08 10:44:56,754 INFO  [tc.qua.io/.0] (build-4) Container quay.io/infinispan/server:14.0 is starting: bd629bdd485cd29c4cae4e14a114914f55c0dec028a4175ee0535c4e0f66b531
2024-02-08T10:44:57.1276900Z 2024-02-08 10:44:57,111 INFO  [org.tes.con.wai.str.HttpWaitStrategy] (build-4) /elegant_nightingale: Waiting for 120 seconds for URL: http://localhost:31222/ (where port 31222 maps to container port 11222)
2024-02-08T10:45:04.3393683Z Feb 08, 2024 10:45:04 AM io.quarkus.infinispan.client.deployment.devservices.InfinispanDevServiceProcessor runInfinispanDevService
2024-02-08T10:45:04.3396146Z 2024-02-08 10:45:04,251 INFO  [tc.qua.io/.0] (build-4) Container quay.io/infinispan/server:14.0 started in PT7.671236929S
2024-02-08T10:45:04.3398709Z INFO: The infinispan server is ready to accept connections on localhost:31222
2024-02-08T10:45:04.5397600Z 2024-02-08 10:45:04,507 INFO  [org.tes.doc.DockerClientProviderStrategy] (pool-3-thread-1) Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first
2024-02-08T10:45:04.8401272Z 2024-02-08 10:45:04,749 INFO  [org.tes.doc.DockerClientProviderStrategy] (pool-3-thread-1) Found Docker environment with local Unix socket (unix:///var/run/docker.sock)
2024-02-08T10:45:05.9415710Z ======================================================================================
2024-02-08T10:45:05.9418097Z   native.image.path was not set, making a guess for the correct path of native image
2024-02-08T10:45:05.9421649Z   guessed path: /home/runner/work/camel-quarkus/camel-quarkus/integration-tests/infinispan/target/camel-quarkus-integration-test-infinispan-3.8.0-SNAPSHOT-runner
2024-02-08T10:45:05.9424178Z ======================================================================================
2024-02-08T10:45:05.9440792Z Executing "/home/runner/work/camel-quarkus/camel-quarkus/integration-tests/infinispan/target/camel-quarkus-integration-test-infinispan-3.8.0-SNAPSHOT-runner -Dquarkus.http.port=8081 -Dquarkus.http.ssl-port=8444 -Dtest.url=http://localhost:8081 -Dquarkus.log.file.path=/home/runner/work/camel-quarkus/camel-quarkus/integration-tests/infinispan/target/quarkus.log -Dquarkus.log.file.enable=true -Dquarkus.log.category."io.quarkus".level=INFO -Dcamel.component.infinispan.*** -Dquarkus.infinispan-client.hosts=localhost:31222 -Dcamel.component.infinispan.hosts=localhost:31222 -Dcamel.component.infinispan.sasl-mechanism=DIGEST-MD5 -Dcamel.component.infinispan.security-realm=default -Dquarkus.native.builder-image.pull=missing -Dcamel.component.infinispan.secure=true -Dquarkus.infinispan-client.*** -Dcamel.component.infinispan.username=admin -Dcamel.component.infinispan.security-server-name=infinispan -Dquarkus.infinispan-client.client-intelligence=BASIC -Dquarkus.infinispan-client.username=admin -Dcamel.component.infinispan.autowired-enabled=false -Dcamel.component.infinispan.configuration-properties=#additionalConfig"
2024-02-08T10:45:05.9452105Z 2024-02-08 10:45:05,903 INFO  [org.apa.cam.qua.cor.CamelBootstrapRecorder] (main) Bootstrap runtime: org.apache.camel.quarkus.main.CamelMainRuntime
2024-02-08T10:45:05.9453334Z 2024-02-08 10:45:05,903 INFO  [org.apa.cam.mai.MainSupport] (main) Apache Camel (Main) 4.3.0 is starting
2024-02-08T10:45:05.9454620Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main) Auto-configuration summary
2024-02-08T10:45:05.9455704Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.secure=true
2024-02-08T10:45:05.9457141Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.***
2024-02-08T10:45:05.9458444Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.securityServerName=infinispan
2024-02-08T10:45:05.9459742Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.username=xxxxxx
2024-02-08T10:45:05.9461268Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.hosts=localhost:31222
2024-02-08T10:45:05.9462557Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.autowiredEnabled=false
2024-02-08T10:45:05.9463852Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.saslMechanism=DIGEST-MD5
2024-02-08T10:45:05.9465153Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.securityRealm=default
2024-02-08T10:45:05.9466571Z 2024-02-08 10:45:05,905 INFO  [org.apa.cam.mai.BaseMainSupport] (main)     [JVM System Property]          camel.component.infinispan.configurationProperties=#additionalConfig
2024-02-08T10:45:05.9468568Z 2024-02-08 10:45:05,910 INFO  [org.apa.cam.imp.eng.AbstractCamelContext] (main) Apache Camel 4.3.0 (camel-1) is starting
2024-02-08T10:45:05.9471984Z 2024-02-08 10:45:05,911 ERROR [org.apa.cam.imp.eng.AbstractCamelContext] (main) Error starting CamelContext (camel-1) due to exception thrown: Failed to start route route1 because of org.infinispan.commons.CacheConfigurationException: org.apache.camel.FailedToStartRouteException: Failed to start route route1 because of org.infinispan.commons.CacheConfigurationException
2024-02-08T10:45:05.9474180Z 	at org.apache.camel.impl.engine.RouteService.warmUp(RouteService.java:122)
2024-02-08T10:45:05.9475081Z 	at org.apache.camel.impl.engine.InternalRouteStartupManager.doWarmUpRoutes(InternalRouteStartupManager.java:308)
2024-02-08T10:45:05.9476401Z 	at org.apache.camel.impl.engine.InternalRouteStartupManager.safelyStartRouteServices(InternalRouteStartupManager.java:187)
2024-02-08T10:45:05.9477599Z 	at org.apache.camel.impl.engine.InternalRouteStartupManager.doStartOrResumeRoutes(InternalRouteStartupManager.java:144)
2024-02-08T10:45:05.9478647Z 	at org.apache.camel.impl.engine.AbstractCamelContext.doStartCamel(AbstractCamelContext.java:2778)
2024-02-08T10:45:05.9479588Z 	at org.apache.camel.impl.engine.AbstractCamelContext.doStartContext(AbstractCamelContext.java:2459)
2024-02-08T10:45:05.9480492Z 	at org.apache.camel.impl.engine.AbstractCamelContext.doStart(AbstractCamelContext.java:2414)
2024-02-08T10:45:05.9481285Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9482056Z 	at org.apache.camel.impl.engine.AbstractCamelContext.start(AbstractCamelContext.java:2019)
2024-02-08T10:45:05.9482853Z 	at org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:208)
2024-02-08T10:45:05.9483908Z 	at org.apache.camel.quarkus.main.CamelMain.doStart(CamelMain.java:94)
2024-02-08T10:45:05.9485024Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9486172Z 	at org.apache.camel.quarkus.main.CamelMain.startEngine(CamelMain.java:140)
2024-02-08T10:45:05.9487308Z 	at org.apache.camel.quarkus.main.CamelMainRuntime.start(CamelMainRuntime.java:49)
2024-02-08T10:45:05.9488943Z 	at org.apache.camel.quarkus.core.CamelBootstrapRecorder.start(CamelBootstrapRecorder.java:45)
2024-02-08T10:45:05.9490405Z 	at io.quarkus.deployment.steps.CamelBootstrapProcessor$boot173480958.deploy_0(Unknown Source)
2024-02-08T10:45:05.9491802Z 	at io.quarkus.deployment.steps.CamelBootstrapProcessor$boot173480958.deploy(Unknown Source)
2024-02-08T10:45:05.9492610Z 	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
2024-02-08T10:45:05.9493157Z 	at io.quarkus.runtime.Application.start(Application.java:101)
2024-02-08T10:45:05.9493851Z 	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111)
2024-02-08T10:45:05.9494486Z 	at io.quarkus.runtime.Quarkus.run(Quarkus.java:71)
2024-02-08T10:45:05.9494918Z 	at io.quarkus.runtime.Quarkus.run(Quarkus.java:44)
2024-02-08T10:45:05.9495360Z 	at io.quarkus.runtime.Quarkus.run(Quarkus.java:124)
2024-02-08T10:45:05.9495819Z 	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
2024-02-08T10:45:05.9496532Z Caused by: org.apache.camel.RuntimeCamelException: org.infinispan.commons.CacheConfigurationException
2024-02-08T10:45:05.9497379Z 	at org.apache.camel.support.ChildServiceSupport.start(ChildServiceSupport.java:67)
2024-02-08T10:45:05.9498172Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9498979Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:113)
2024-02-08T10:45:05.9499782Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:153)
2024-02-08T10:45:05.9500537Z 	at org.apache.camel.impl.engine.DefaultChannel.doStart(DefaultChannel.java:129)
2024-02-08T10:45:05.9501236Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9501976Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9502775Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:113)
2024-02-08T10:45:05.9503561Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:139)
2024-02-08T10:45:05.9504344Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:115)
2024-02-08T10:45:05.9505344Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:153)
2024-02-08T10:45:05.9506057Z 	at org.apache.camel.processor.Pipeline.doStart(Pipeline.java:205)
2024-02-08T10:45:05.9506703Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9507446Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9508238Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:113)
2024-02-08T10:45:05.9509114Z 	at org.apache.camel.support.processor.DelegateAsyncProcessor.doStart(DelegateAsyncProcessor.java:89)
2024-02-08T10:45:05.9509947Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9510697Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9511494Z 	at org.apache.camel.impl.engine.RouteService.startChildServices(RouteService.java:395)
2024-02-08T10:45:05.9512237Z 	at org.apache.camel.impl.engine.RouteService.doWarmUp(RouteService.java:192)
2024-02-08T10:45:05.9512931Z 	at org.apache.camel.impl.engine.RouteService.warmUp(RouteService.java:120)
2024-02-08T10:45:05.9513411Z 	... 23 more
2024-02-08T10:45:05.9513761Z Caused by: org.infinispan.commons.CacheConfigurationException
2024-02-08T10:45:05.9514737Z 	at org.infinispan.client.hotrod.configuration.RemoteCacheConfigurationBuilder.configurationURI(RemoteCacheConfigurationBuilder.java:148)
2024-02-08T10:45:05.9516118Z 	at org.infinispan.client.hotrod.configuration.RemoteCacheConfigurationBuilder.lambda$withProperties$1(RemoteCacheConfigurationBuilder.java:269)
2024-02-08T10:45:05.9517491Z 	at org.infinispan.client.hotrod.configuration.RemoteCacheConfigurationBuilder.findCacheProperty(RemoteCacheConfigurationBuilder.java:298)
2024-02-08T10:45:05.9518979Z 	at org.infinispan.client.hotrod.configuration.RemoteCacheConfigurationBuilder.withProperties(RemoteCacheConfigurationBuilder.java:269)
2024-02-08T10:45:05.9520263Z 	at org.infinispan.client.hotrod.configuration.ConfigurationBuilder.withProperties(ConfigurationBuilder.java:550)
2024-02-08T10:45:05.9521368Z 	at org.apache.camel.component.infinispan.remote.InfinispanRemoteManager.doStart(InfinispanRemoteManager.java:125)
2024-02-08T10:45:05.9522264Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9523017Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9524181Z 	at org.apache.camel.component.infinispan.remote.InfinispanRemoteEndpoint.doStart(InfinispanRemoteEndpoint.java:61)
2024-02-08T10:45:05.9525096Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9525842Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9526600Z 	at org.apache.camel.processor.SendProcessor.doStart(SendProcessor.java:242)
2024-02-08T10:45:05.9527290Z 	at org.apache.camel.support.service.BaseService.start(BaseService.java:113)
2024-02-08T10:45:05.9528028Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:126)
2024-02-08T10:45:05.9528831Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:113)
2024-02-08T10:45:05.9530096Z 	at org.apache.camel.support.service.ServiceHelper.startService(ServiceHelper.java:153)
2024-02-08T10:45:05.9531109Z 	at org.apache.camel.processor.errorhandler.RedeliveryErrorHandler.doStart(RedeliveryErrorHandler.java:1698)
2024-02-08T10:45:05.9532012Z 	at org.apache.camel.support.ChildServiceSupport.start(ChildServiceSupport.java:60)
2024-02-08T10:45:05.9532537Z 	... 43 more
2024-02-08T10:45:05.9532796Z Caused by: java.lang.NullPointerException
2024-02-08T10:45:05.9533680Z 	at org.infinispan.client.hotrod.configuration.RemoteCacheConfigurationBuilder.configurationURI(RemoteCacheConfigurationBuilder.java:144)
2024-02-08T10:45:05.9534510Z 	... 60 more

@karesti
Copy link
Contributor Author

karesti commented Feb 8, 2024

ahh yes, I'll add the missing config

@karesti
Copy link
Contributor Author

karesti commented Feb 8, 2024

@jamesnetherton I'm going to simplify something

@karesti
Copy link
Contributor Author

karesti commented Feb 8, 2024

@jamesnetherton look good now

@jamesnetherton jamesnetherton merged commit 22b77ed into apache:main Feb 8, 2024
22 of 23 checks passed
@jamesnetherton
Copy link
Contributor

Thanks a lot for this @karesti.

@karesti karesti deleted the changes-suggested branch February 8, 2024 16:32
@zbendhiba
Copy link
Contributor

Many thanks @karesti !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants