Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alternative-jdk job a matrix build #5726

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

jamesnetherton
Copy link
Contributor

The integration-tests-alternative-jdk CI job has been failing for reasons that I cannot determine. I suspect it's due to running out of disk space. Hence this attempt at reclaiming some space.

@jamesnetherton
Copy link
Contributor Author

Well... the job completed at least. But this change breaks the JMS & Infinispan tests because the 'common' bits they depend on get cleaned up.

Not sure what else we can do aside from splitting the job up.

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok spotted, it has indeed failed in the middle of a build for non reported reason.
Let's see how the clean helps.

@aldettinger
Copy link
Contributor

Well... the job completed at least. But this change breaks the JMS & Infinispan tests because the 'common' bits they depend on get cleaned up.

Not sure what else we can do aside from splitting the job up.

Ah shame, so it's probably not a good idea. No other ideas than splitting on my side.
There does not seem to have that much articles about disk saving technics out there.

@jamesnetherton
Copy link
Contributor Author

Lets see if cleaning up the Downloaded maven repo archive helps...

@jamesnetherton jamesnetherton changed the title Remove target directory on test completion in alternative-jdk job Make alternative-jdk job a matrix build Feb 8, 2024
@jamesnetherton
Copy link
Contributor Author

Tweaked things to split the alt-jdk job into two parts.

@jamesnetherton
Copy link
Contributor Author

@aldettinger CI checks passed. WDYT about the change?

@aldettinger
Copy link
Contributor

@aldettinger CI checks passed. WDYT about the change?

This is the best solution so far. A neat improvement could be one day to cut at other letter than "n", as the first job takes 52m and the second one 22m.

Out of curiosity, what about infra capacity ? We can add as many jobs from matrix as we want and they are spread across available nodes ?

@jamesnetherton
Copy link
Contributor Author

This is the best solution so far. A neat improvement could be one day to cut at other letter than "n", as the first job takes 52m and the second one 22m.

Yeah it's not super optimized in the current state.

Out of curiosity, what about infra capacity ? We can add as many jobs from matrix as we want and they are spread across available nodes ?

This change actually takes us over the limit of concurrent jobs. The native Group 13 tests are left in the pending state until one of the other jobs completes. Which usually happens in around 15 - 20 minutes. So it's not a big delay.

@jamesnetherton
Copy link
Contributor Author

Applied the same changes to the nightly workflows.

@jamesnetherton jamesnetherton merged commit eb75742 into apache:main Feb 8, 2024
24 checks passed
@jamesnetherton jamesnetherton deleted the alt-jdk-free-disk-space branch February 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants