Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Elasticsearch Low Level Rest Client #5738

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

zbendhiba
Copy link
Contributor

Fixes #5736

I created a follow up issue to add more test coverage. #5737

@zbendhiba
Copy link
Contributor Author

The test failure seems unrelated. Is master-openshift considered a flaky test ?

@jamesnetherton
Copy link
Contributor

The test failure seems unrelated. Is master-openshift considered a flaky test ?

It got enabled yesterday after being disabled for a long time. I will try to take a look into it.

@zbendhiba
Copy link
Contributor Author

thanks @jamesnetherton !

@Path("/load/component/elasticsearch-rest-client")
@GET
@Produces(MediaType.TEXT_PLAIN)
public Response loadComponentElasticsearchRestClient() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the auto-generated resource / test ? Like if index test is passing, we know for the sure the component can be loaded ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I'll add that to the follow up issue

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failure is probably related to re-formatting need only.

@zbendhiba If one is currently implementing an example that transform data and load it into ElasticSearch. Would you advise to use this low level rest client ? or camel-quarkus-elasticsearch ?

Fixes apache#5736

Co-authored-by: James Netherton <jamesnetherton@users.noreply.github.com>
@zbendhiba
Copy link
Contributor Author

LGTM, the failure is probably related to re-formatting need only.

@zbendhiba If one is currently implementing an example that transform data and load it into ElasticSearch. Would you advise to use this low level rest client ? or camel-quarkus-elasticsearch ?

For now, I think it depends really on preference.

Once we push those 2 in native mode, one should look at what is the status of the transitive quarkus extensions: are they on preview or fully supported?

@zbendhiba
Copy link
Contributor Author

I pushed again because of format error and squashed commits

@zbendhiba zbendhiba merged commit 5e0fe36 into apache:main Feb 13, 2024
24 checks passed
@zbendhiba zbendhiba deleted the elasticsearch branch February 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Elasticsearch Low Level Rest Client
4 participants