-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elasticsearch Low Level Rest Client #5738
Conversation
The test failure seems unrelated. Is master-openshift considered a flaky test ? |
...g/apache/camel/quarkus/component/elasticsearch/rest/client/it/ElasticsearchTestResource.java
Outdated
Show resolved
Hide resolved
It got enabled yesterday after being disabled for a long time. I will try to take a look into it. |
thanks @jamesnetherton ! |
@Path("/load/component/elasticsearch-rest-client") | ||
@GET | ||
@Produces(MediaType.TEXT_PLAIN) | ||
public Response loadComponentElasticsearchRestClient() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the auto-generated resource / test ? Like if index test is passing, we know for the sure the component can be loaded ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I'll add that to the follow up issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the failure is probably related to re-formatting need only.
@zbendhiba If one is currently implementing an example that transform data and load it into ElasticSearch. Would you advise to use this low level rest client ? or camel-quarkus-elasticsearch ?
Fixes apache#5736 Co-authored-by: James Netherton <jamesnetherton@users.noreply.github.com>
9b24921
to
22e4219
Compare
For now, I think it depends really on preference. Once we push those 2 in native mode, one should look at what is the status of the transitive quarkus extensions: are they on preview or fully supported? |
I pushed again because of format error and squashed commits |
Fixes #5736
I created a follow up issue to add more test coverage. #5737