feat(camel-k): add options to override some aspects of a route #5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davsclaus mind having a look ? |
lburgazzoli
force-pushed
the
camel-k-route-rewire
branch
from
9e12430
to
4809f76
Compare
oscerd
approved these changes
Feb 22, 2024
integration-tests/camel-k-runtime-model-reifier/src/test/resources/conf.properties
Outdated
Show resolved
Hide resolved
| "camel.k.routes.overrides[4].input.with", "direct:r5invalid", | ||
| "camel.k.routes.overrides[5].id", "r5", | ||
| "camel.k.routes.overrides[5].input.with", "direct:r5override", | ||
| "camel.k.sources[0].location", "file:src/test/resources/routes.yaml", |
There was a problem hiding this comment.
file:src/test/resources/routes.yaml wont work when the test is run in the Quarkus Platform since the test is run from the test-jar. Better to copy any required resources into target or a temporary location.
There was a problem hiding this comment.
let me fix that
There was a problem hiding this comment.
moved to classpath reolver, would that work on Quarkus Platform @jamesnetherton ?
There was a problem hiding this comment.
Yeah it should be ok
lburgazzoli
force-pushed
the
camel-k-route-rewire
branch
from
4809f76
to
f0ba93e
Compare
|
I guess we'd want this backported to 3.8.x? |
if that is not an issue, yes |
aldettinger
approved these changes
Feb 22, 2024
lburgazzoli
force-pushed
the
camel-k-route-rewire
branch
from
f0ba93e
to
25ee0ee
Compare
|
@jamesnetherton should I backport ? |
oh you did it already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.