Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up camel-k extension leftovers #5802

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

lburgazzoli
Copy link
Contributor

  • interceptors are not more needed
  • customizers are not more needed
  • custom source loader not more needed and replaced with camel.main.routes-include-pattern
  • custom "Runtime" not more needed

@lburgazzoli lburgazzoli force-pushed the camel-k-cleanup branch 8 times, most recently from faaf778 to 2679839 Compare February 28, 2024 13:29
@lburgazzoli lburgazzoli marked this pull request as ready for review February 28, 2024 15:59
@jamesnetherton
Copy link
Contributor

Any idea if these Groovy bits are still required (I'm assuming they are for Groovy support)?

https://github.com/apache/camel-quarkus/blob/main/poms/bom/pom.xml#L6599-L6623

Also is this test related stuff is still needed?

https://github.com/apache/camel-quarkus/blob/main/poms/bom-test/pom.xml#L135-L144

@lburgazzoli
Copy link
Contributor Author

Any idea if these Groovy bits are still required (I'm assuming they are for Groovy support)?

main/poms/bom/pom.xml#L6599-L6623

Also is this test related stuff is still needed?

main/poms/bom-test/pom.xml#L135-L144

Removed, let see

- interceptors are not more needed
- customizers are not more needed
- custom source loader not more needed and replaced with camel.main.routes-include-pattern
- custom "Runtime" not more needed
@lburgazzoli
Copy link
Contributor Author

Any idea if these Groovy bits are still required (I'm assuming they are for Groovy support)?

main/poms/bom/pom.xml#L6599-L6623

it looks like removing them does not cause any issue. Since the camel-k now leverages camel-groovy from core/quarkus, I guess they are not more needed.

Also is this test related stuff is still needed?

main/poms/bom-test/pom.xml#L135-L144

Those were not needed

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I left a couple of comments for some minor things to fix up.

<description>Integration tests for Camel Quarkus K Runtime Shutdown extension</description>

<properties>
<quarkus.runner.jar>${project.build.directory}/quarkus-app/quarkus-run.jar</quarkus.runner.jar>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the runnable JAR is never packaged in the platform build, we'll need to exclude these tests there.

You can exclude the test module here:

https://github.com/apache/camel-quarkus/blob/main/tooling/test-list/pom.xml#L57

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</dependency>
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-platform-http-deployment</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can remove platform-http & rest from this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, also removed other deps not needed

@jamesnetherton
Copy link
Contributor

Hopefully the final question - is this still needed?

https://github.com/apache/camel-quarkus/tree/main/tooling/camel-k-maven-plugin

@lburgazzoli
Copy link
Contributor Author

Hopefully the final question - is this still needed?

main/tooling/camel-k-maven-plugin

yes, at least for some time it will be still required hoping to find a better solutions and eventually get rid of it.
@claudio4j will likely improving it to make it on par with what we have now in the camel-k-runtime repo.

@jamesnetherton jamesnetherton merged commit 8555b89 into apache:main Feb 29, 2024
24 checks passed
@lburgazzoli lburgazzoli deleted the camel-k-cleanup branch February 29, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants