jt400 mock coverage + native fixes #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriOndrusek
force-pushed
the
jt400-mock-tests
branch
from
b75ddc8
to
d29bf5b
Compare
...ion-tests/jt400/src/test/java/org/apache/camel/quarkus/component/jt400/it/Jt400MockTest.java
Outdated
Show resolved
Hide resolved
...oyment/src/main/java/org/apache/camel/quarkus/component/jt400/deployment/Jt400Processor.java
Outdated
Show resolved
Hide resolved
oscerd
approved these changes
Feb 27, 2024
JiriOndrusek
force-pushed
the
jt400-mock-tests
branch
from
d29bf5b
to
de8871f
Compare
|
@jamesnetherton All changes are amended into the PR. |
|
@JiriOndrusek need backport to |
@JiriOndrusek I still see the |
JiriOndrusek
force-pushed
the
jt400-mock-tests
branch
from
de8871f
to
eaf906b
Compare
Sorry for that, I fixed 1 place and there were others. I checked the PR now and there is no such occurrence anymore/ |
Thanks for the reminder! I added the label. |
jamesnetherton
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5809
The mocked tests require
quarkus.test.flat-class-pathto betrue. (default behavior for the tests)New profile
skip-mock-testsreturns flat-class-path tofalseand disables all mocked tests.Profile is not active by default and can be activated by property
-Dskip-mock-tests=truefor the execution.Test coverage is quite small - there are tests to read/write for keyed data-queue and message-queue, and the test for the program call.
Mocked backend is not based on the real server, therefore the response are probably far from the real responses
This mocked tests could be refactored in the future to mimic real responses. Now it allows extension to be tested in the native mode (to some extent).