-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quarkus master split #5922
quarkus master split #5922
Conversation
lburgazzoli
commented
Mar 25, 2024
- Move Kubernetes cluster service to its own module
- Move FileLock cluster service to its own module
b249251
to
bf045a2
Compare
d01aadf
to
d523949
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left some comments for some minor things to fix up.
...nsions/kubernetes-cluster-service/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Outdated
Show resolved
Hide resolved
d523949
to
c28dbde
Compare
c28dbde
to
3fcbca3
Compare
3fcbca3
to
c270762
Compare
@jamesnetherton @zhfeng it should be ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lburgazzoli please check the CI failures, it looks cluster-leader-election
examples is not working due to these changnes?
extensions/telegram/runtime/src/main/resources/META-INF/quarkus-extension.yaml
Show resolved
Hide resolved
I guess the fix should be done in the camel-quarkus-examples ? but there is a chicken-egg problem as the camel-quarkus-file-cluster-service won't be available till this get merged so a pr on the camel-quarkus-examples would probably fail. |
c270762
to
813493c
Compare
813493c
to
cacfc65
Compare
@jamesnetherton @zhfeng what should I do with this ? I can temporarily rework the example not to require any cluster service extension if it makes sense |
If you're ok leaving this PR open until after we get the 3.9.0 release completed (hopefully tomorrow / thursday), then afterwards we can just merge this and immediately adjust the example project. |
no objections |