Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus master split #5922

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

lburgazzoli
Copy link
Contributor

  • Move Kubernetes cluster service to its own module
  • Move FileLock cluster service to its own module

@lburgazzoli lburgazzoli force-pushed the quarkus-master-split branch 2 times, most recently from b249251 to bf045a2 Compare March 25, 2024 10:40
@lburgazzoli lburgazzoli marked this pull request as ready for review March 25, 2024 10:44
@lburgazzoli lburgazzoli force-pushed the quarkus-master-split branch 2 times, most recently from d01aadf to d523949 Compare March 25, 2024 10:52
Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some comments for some minor things to fix up.

extensions/file-cluster-service/runtime/pom.xml Outdated Show resolved Hide resolved
extensions/file-cluster-service/pom.xml Outdated Show resolved Hide resolved
extensions/file-cluster-service/runtime/pom.xml Outdated Show resolved Hide resolved
@lburgazzoli
Copy link
Contributor Author

@jamesnetherton @zhfeng it should be ready now

Copy link
Contributor

@zhfeng zhfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lburgazzoli please check the CI failures, it looks cluster-leader-election examples is not working due to these changnes?

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Mar 26, 2024

@lburgazzoli please check the CI failures, it looks cluster-leader-election examples is not working due to these changnes?

I guess the fix should be done in the camel-quarkus-examples ? but there is a chicken-egg problem as the camel-quarkus-file-cluster-service won't be available till this get merged so a pr on the camel-quarkus-examples would probably fail.

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Mar 26, 2024

@jamesnetherton @zhfeng what should I do with this ? I can temporarily rework the example not to require any cluster service extension if it makes sense

@jamesnetherton
Copy link
Contributor

I can temporarily rework the example not to require any cluster service extension if it makes sense

If you're ok leaving this PR open until after we get the 3.9.0 release completed (hopefully tomorrow / thursday), then afterwards we can just merge this and immediately adjust the example project.

@lburgazzoli
Copy link
Contributor Author

no objections

@jamesnetherton jamesnetherton merged commit d4540b6 into apache:main Mar 28, 2024
23 of 24 checks passed
@jamesnetherton
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants