Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findbugs exclusion from quarkus-grpc-common in gRPC extension #5978

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, they don't break the enforcer check anymore ? should we then remove it from there https://github.com/apache/camel-quarkus/blob/main/extensions/qdrant/runtime/pom.xml#L41 too ?

@jamesnetherton
Copy link
Contributor Author

should we then remove it

I think it depends on the findbugs usage. If a qdrant app can run ok in dev mode, then it's probably fine to leave things as-is.

For gRPC it fails in dev mode with the exclusion because the grpc-java codebase is littered with javax.annotation.CheckReturnValue in various places.

@zhfeng zhfeng merged commit 09aa7fe into apache:main Apr 8, 2024
24 checks passed
@jamesnetherton jamesnetherton deleted the grpc-remove-findbugs-exclude branch April 8, 2024 11:53
@aldettinger
Copy link
Contributor

should we then remove it

I think it depends on the findbugs usage. If a qdrant app can run ok in dev mode, then it's probably fine to leave things as-is.

For gRPC it fails in dev mode with the exclusion because the grpc-java codebase is littered with javax.annotation.CheckReturnValue in various places.

Ok, looks to run good. Many thanks for the tip @jamesnetherton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants