-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jt400: tests are not cleaning after themselves and parallel run fails #6001
Jt400: tests are not cleaning after themselves and parallel run fails #6001
Conversation
c507f8a
to
4f07cae
Compare
Failure is not related
|
Just so I understand things better. The docs state What that means is that if you start parallel test executions, they will be queued and wait for each other to complete? |
I used a keyed dataque (FIFO).
If the token is not its own
Dead lock prevention
I tested the scenario several times with 9 parallel executions |
Therefore only 1 token (thus 1 participant) is allowed to run the tests, the others have to wait |
@jamesnetherton I'll add my previous comment (with explanation) as a code comment to locking method |
4f07cae
to
8c44279
Compare
|
8c44279
to
cea672a
Compare
fixes #5999
This PR fixes tests behavior in several corner cases.
clear all
which clears all queues used by the test, This behavior is described in the readme.adoc and is suggested t o use during development.cq.jt400.global-lock
(described in readme.adoc).clear-all
clears the lock queue, therefore there it tests can not be blocked forever.The coverage or test amount stays the same.