Fix #5824 to add camel trace config properties #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davsclaus
reviewed
May 29, 2024
...ions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelContextRecorder.java
Outdated
Show resolved
Hide resolved
extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelConfig.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
May 29, 2024
extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/CamelConfig.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
May 30, 2024
| BacklogTracer tracer = null; | ||
| if (registry != null) { | ||
| // lookup in registry | ||
| Map<String, BacklogTracer> map = registry.findByTypeWithName(BacklogTracer.class); |
There was a problem hiding this comment.
What happen if we don't look in the registry ? Shouldn't the tracer be accessible from getContextPlugin always ? Maybe, this is related to stand by mode ?
There was a problem hiding this comment.
Hmm, I borrow some codes from DefualtChannel::getOrCreateBacklogTracer(), @davsclaus any idea?
There was a problem hiding this comment.
The history lead up to camel 3 refactoring, might be there since even longer. As we are in line with camel-core, it should be fine to validate the pr.
Still it would be interesting to get the explanation if anyone remember :)
aldettinger
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5824