Fix hashicorp-vault extension #6255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesnetherton
force-pushed
the
hashicorp-vault-fix
branch
from
3aa0fc1
to
39d93c6
Compare
oscerd
approved these changes
Jul 5, 2024
aldettinger
reviewed
Jul 5, 2024
...est/src/test/java/org/apache/camel/quarkus/support/spring/test/web/SpringWebSupportTest.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
Jul 5, 2024
.../main/java/org/apache/camel/quarkus/component/hashicorp/vault/it/HashicorpVaultResource.java
Show resolved
Hide resolved
aldettinger
reviewed
Jul 5, 2024
.../main/java/org/apache/camel/quarkus/component/hashicorp/vault/it/HashicorpVaultResource.java
Show resolved
Hide resolved
jamesnetherton
force-pushed
the
hashicorp-vault-fix
branch
from
39d93c6
to
fcf41ff
Compare
aldettinger
approved these changes
Jul 5, 2024
|
I'll set this to draft until I figure out the missing shaded classes. Strange that I don't see the failures happen locally... |
jamesnetherton
force-pushed
the
hashicorp-vault-fix
branch
2 times, most recently
from
ec1dd7e
to
478959e
Compare
|
What's the status on this? |
I can try to revisit it for 3.15.0. I was hoping to not have to include most of spring-web because it's a magnet for CVEs. But, I'll probably just include it as-is to get things working again. |
jamesnetherton
force-pushed
the
hashicorp-vault-fix
branch
from
478959e
to
782d248
Compare
|
Reworked things to use the unaltered |
Fixes apache#6254 * Depend on camel-quarkus-support-spring * Unban spring-web * Add integration tests
jamesnetherton
force-pushed
the
hashicorp-vault-fix
branch
from
782d248
to
7d86df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.