Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using filesystem instead of classpath for certificates from target/certs #6356

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

JiriOndrusek
Copy link
Contributor

fixes #6355

This PR changes default location of generated certificates to target/certs
and changes the way of reading the certificates by using filesystem (instead of classpath resource)

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggested changes to help verify that we definitely are reading certs from the file system and not the classpath.

@JiriOndrusek
Copy link
Contributor Author

@jamesnetherton Thanks for the suggestions, I fixed them all.
I think that the PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests with certificate generator test support fail in native if surefire is disabled
4 participants