Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for 'Fop native failures due to pdfbox 3 upgrade' #1 #6744

Conversation

fugerit79
Copy link
Contributor

@fugerit79 fugerit79 commented Nov 4, 2024

fugerit79/issues/1
#5244
#5234

This PR's goal is to
Fix #6743

And document on camel-quarkus-fop limitations page the fact that native profile is currenlty disabled.

[X] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[X] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[X] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[X] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[X] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

@fugerit79 fugerit79 force-pushed the 1-documentation-for-issue-5244-fop-native-failures-due-to-pdfbox-3-upgrade-6743 branch from 2e16985 to 30b131b Compare November 6, 2024 10:08
@zhfeng
Copy link
Contributor

zhfeng commented Nov 9, 2024

Thanks @fugerit79 - can you run the following command locally to regen the docs module as well.

./mvnw -f extensions/fop/runtime/pom.xml clean install

@fugerit79
Copy link
Contributor Author

Thanks @zhfeng , the docs module has been generated.

Is there anything else I can do?

@fugerit79 fugerit79 force-pushed the 1-documentation-for-issue-5244-fop-native-failures-due-to-pdfbox-3-upgrade-6743 branch from d2eb227 to 5f1bbc1 Compare November 9, 2024 08:37
@jamesnetherton
Copy link
Contributor

This may actually not be needed in the next release. FOP in Camel 4.9.0 will use pdfbox 3.x.

@fugerit79
Copy link
Contributor Author

@jamesnetherton as you think, but I lost some time before understanding why the native profile was not working.
Is there any due date for the release? And are we sure the native profile will work again for camel-quarkus-fop?

If there are no proof that the native build will work again for sure, I would rather update the documentation and then update it again.

So I guess would better to document the issue right now.

@jamesnetherton
Copy link
Contributor

jamesnetherton commented Nov 11, 2024

And are we sure the native profile will work again for camel-quarkus-fop

I need to investigate it. But I don't see why it can't be made to work when we have the correct pdfbox version.

Anyway, I'll merge this for now until it's fixed.

@jamesnetherton jamesnetherton merged commit 7c457ee into apache:main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for issue 5244 : Fop native failures due to pdfbox 3 upgrade
3 participants