Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.15.x] Upgrade QCXF to 3.15.3 #6781

Closed
wants to merge 1 commit into from

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Nov 13, 2024

No description provided.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a less intrusive variant

@ppalaga
Copy link
Contributor

ppalaga commented Nov 13, 2024

@zhfeng this is the idea: #6782

Instead of removing all bannedDependencyResources, we just remove findbugs from camel-quarkus-banned-dependencies.xml using your elegant technique with passing the allow-findbugs property via Maven filtering.

The question at the bottom line is whether we should not give up banning findbugs altogether, given we allow it somewhere. The original motivation was to prevent multiple versions of findbugs in the transitive closure, thus making the downstream packaging easier. I think the machinery to allow it somewhere and ban elsewhere starts to be too complicated. In other words I would not mind stopping to ban findbugs altogether.

What do others think?

@jamesnetherton
Copy link
Contributor

I would not mind stopping to ban findbugs altogether

Agreed. The ban / unban stuff will just get increasingly harder to maintain.

@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 13, 2024

Thanks @ppalaga - Yeah, I agree as well.

@zhfeng zhfeng closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants