Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bean configuration via HashiCorp Vault example #132

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

Croway
Copy link
Contributor

@Croway Croway commented Jun 12, 2024

No description provided.

@Croway Croway requested a review from davsclaus June 12, 2024 11:09
@davsclaus
Copy link
Contributor

I generally prefer to name keys with myXXX or something like beer, donald-duck or something to make it very obvious its something you can type anything, and not some "fixed" special value you must use.

so its not so easy to know if database can be any value you want, and so on.

@Croway
Copy link
Contributor Author

Croway commented Jun 12, 2024

I generally prefer to name keys with myXXX or something like beer, donald-duck or something to make it very obvious its something you can type anything, and not some "fixed" special value you must use.

so its not so easy to know if database can be any value you want, and so on.

I am a bit confused, do you refer to https://github.com/apache/camel-spring-boot-examples/pull/132/files#diff-bf2471b4f919f5dae04106e4d34966dd292c9a3d30e92eb8bca76952e564a0fbR12 ? should I rename those to myDatabase, myUsername and so on? Do you think it will be more clear?

@davsclaus
Copy link
Contributor

I generally prefer to name keys with myXXX or something like beer, donald-duck or something to make it very obvious its something you can type anything, and not some "fixed" special value you must use.
so its not so easy to know if database can be any value you want, and so on.

I am a bit confused, do you refer to https://github.com/apache/camel-spring-boot-examples/pull/132/files#diff-bf2471b4f919f5dae04106e4d34966dd292c9a3d30e92eb8bca76952e564a0fbR12 ? should I rename those to myDatabase, myUsername and so on? Do you think it will be more clear?

yes

@Croway Croway merged commit 1d3c772 into apache:main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants