Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAMEL-20675] move cluster service implementations to dedicated starters #1130

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Apr 16, 2024

  • [CAMEL-20675] move kubernetes cluster service to its own starter
  • [CAMEL-20675] move file lock cluster service to its own starter
  • [CAMEL-20675] move jgroups raft cluster service to its own starter
  • [CAMEL-20675] move jgroups lock cluster service to its own starter
  • [CAMEL-20675] move zookeeper cluster service to its own starter
  • [CAMEL-20675] move infinispan remote cluster service to its own starter
  • [CAMEL-20675] move consul cluster service to its own starter
  • [CAMEL-20675] regen

I'll squash the commits before merge

@lburgazzoli
Copy link
Contributor Author

This is a draft implementation of CAMEL-20675, for the code POV, I think it is pretty ready, but I don't know how to deal with the documentation.

@davsclaus
Copy link
Contributor

Today I think there are not much docs, the only thing is those tables with all the SB starter options. And with this PR those for cluster/cloud is moved out.

I guess if you add src/main/docs and add adoc for those new starters then they ought to show up in the website, but that is something we can look at after the code changes.

What about Quarkus should its stuff also be moved out, or we dont have this kind for CEQ today.

@davsclaus
Copy link
Contributor

How do we keep those json files up to date, if you do a change in the java file, then the json file is updated also ?

@Croway
Copy link
Contributor

Croway commented Apr 16, 2024

This is a draft implementation of CAMEL-20675, for the code POV, I think it is pretty ready, but I don't know how to deal with the documentation.

Hi @lburgazzoli regarding documentation, we may mention it in the release notes, wdyt?

@lburgazzoli
Copy link
Contributor Author

Today I think there are not much docs, the only thing is those tables with all the SB starter options. And with this PR those for cluster/cloud is moved out.

Yeas I was mainly trying to find out how to include such properties somewhere

I guess if you add src/main/docs and add adoc for those new starters then they ought to show up in the website, but that is something we can look at after the code changes.

+1

What about Quarkus should its stuff also be moved out, or we dont have this kind for CEQ today.

For Quarkus I did it already (as today the only have support for kubernetes and file cluster service)

@lburgazzoli
Copy link
Contributor Author

This is a draft implementation of CAMEL-20675, for the code POV, I think it is pretty ready, but I don't know how to deal with the documentation.

Hi @lburgazzoli regarding documentation, we may mention it in the release notes, wdyt?

Definitively

@lburgazzoli
Copy link
Contributor Author

How do we keep those json files up to date, if you do a change in the java file, then the json file is updated also ?

Yes they are, those json have been auto generated bu some of the maven/camel/sb plugins

@lburgazzoli lburgazzoli marked this pull request as ready for review April 17, 2024 06:58
@davsclaus
Copy link
Contributor

Need to update the 4.6 upgrade guide doc with this change (in core project)

@lburgazzoli
Copy link
Contributor Author

Need to update the 4.6 upgrade guide doc with this change (in core project)

apache/camel#13830, let me know if you want to expand it more

@lburgazzoli lburgazzoli merged commit ff94099 into apache:main Apr 17, 2024
2 checks passed
@lburgazzoli lburgazzoli deleted the CAMEL-20675-cluster-services branch April 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants