Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-18963: upgrade both spring-boot starters using camel-openapi-java #837

Merged
merged 1 commit into from
May 13, 2023

Conversation

klease
Copy link
Contributor

@klease klease commented May 11, 2023

Modify the AutoConfiguration classes to use the modified return type in RestOpenApiReader.read method. Since OpenAPI is now directly returned there is no need to convert it to json and reparse it with swagger. In addition, this change allows handling of an OpenAPI 2.x specification which will be automatically upgraded to OpenAPI 3.x. Previously this would have failed due to the direct use of OpenAPIV3Parser.

Modify the AutoConfiguration classes to use the modified return type in
RestOpenApiReader.read method. Since OpenAPI is now directly returned
there is no need to convert it to json and reparse it with swagger. In
addition, this change allows handling of an OpenAPI 2.x specification
which will be automatically upgraded to OpenAPI 3.x. Previously this
would have failed due to the direct use of OpenAPIV3Parser.
@klease
Copy link
Contributor Author

klease commented May 11, 2023

Waiting for the core camel openapi components to be built.

@klease klease marked this pull request as ready for review May 12, 2023 12:25
@klease
Copy link
Contributor Author

klease commented May 12, 2023

The PR build fails in the camel-kamelet-starter due to a failing test. See CAMEL-19345.

@davsclaus davsclaus merged commit 6490038 into apache:main May 13, 2023
@klease
Copy link
Contributor Author

klease commented May 13, 2023

Merci Claus.

@klease klease deleted the CAMEL-18963 branch May 14, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants