-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ban com.sun.xml.bind:jaxb-impl, replace it with jaxb-runtime where needed #15298
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
Where is this information. Do we have a page that states this. At this page the front page says
|
Thanks for the pointer, @davsclaus. Well, the authoritative resources about JAXB implementations are rather sparse and confusing.
Mainly the last point makes great sense to me. What are other's thoughts? Maybe I am missing something? |
Yeah I can understand that sun is regarded as old - just wanted to make sure that glashfish is really the replacement also for jakarta ee. We need to make sure this kind of change does not cause pain - and should be ready to fix or revert before the 4.8 LTS release. So this would need to check that camel and CSB and CEQ still works aftwards. |
And it would be good to add a note in the 4.8 upgrade docs about this change (so users would be aware) but hopefully they dont need to worried. |
It is fine for Camel Quarkus, where we already merged a similar change apache/camel-quarkus#6382
Where can I do that? |
I wonder if CSB need some kind of update as well since CEQ had that ? |
491de28
to
57f07d3
Compare
Yes, having an enforcer check might be a good idea to make sure that |
Thanks, done in 57f07d3. Please review. |
Description
org.glassfish.jaxb:jaxb-runtime is the new Jakarta implementation of JAXB. It should be preferred to the old com.sun.xml.bind:jaxb-impl
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
No Jira, because this is just housekeeping. But I can create one, if needed.
Apache Camel coding standards and style
mvn clean install -DskipTests
locally from root folder and I have committed all auto-generated changes.