CAMEL-12541: rsClient does not work programmatically, only with XML #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the endpoint is created the bean is always available and is used for the consumer approach (newJAXRSServerFactoryBean). Now the same behavior is used for producer approach (newJAXRSClientFactoryBean).
|
Before creating this PR I'd run the tests and re-ran after inserting the fix to make sure if it was OK or not. I believe CxfRsProducerAddressOverrideTest.testAddressMultiOverride is now breaking because LRUSoftCache returns the wrong stored object here when the test executes line 166. |
|
When the cache works properly it has the following: See that each value is a different object (625487a6 and 36224f93). But when I run a test with this PR I get the following: Both keys have the same object (ab58eea1). That's why the test is breaking. |
WillemJiang
reviewed
May 28, 2018
| @Override | ||
| protected AbstractXmlApplicationContext createApplicationContext() { | ||
| String version = Version.getCurrentVersion(); | ||
|
|
||
| ClassPathXmlApplicationContext applicationContext = null; | ||
|
|
||
| if (version.startsWith("2") && (version.contains("2.5") || version.contains("2.4"))) { |
There was a problem hiding this comment.
This version check could be removed as we already move to 2.6.x
| public void testCreateCxfRsClientFactoryBeanProgrammatically() { | ||
|
|
||
| CxfRsEndpoint endpoint = resolveMandatoryEndpoint("cxfrs://bean://" + BEAN_SERVICE_ENDPOINT_NAME, CxfRsEndpoint.class); | ||
| SpringJAXRSClientFactoryBean cfb = (SpringJAXRSClientFactoryBean)endpoint.createJAXRSClientFactoryBean(); |
There was a problem hiding this comment.
we may need to check the instance of cfb is not the one we set before.
Version check was removed as we already move to 2.6.x
WillemJiang
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the endpoint is created with the bean (see here how it's found) it is always available and is used for the consumer approach (see the method newJAXRSServerFactoryBean).
Now the same behavior is used for producer approach as nowadays we always return a new instance of SpringJAXRSClientFactoryBean.