Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#632: Update changes.md for coming Apache Celix 2.4.0 #634

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Sep 4, 2023

This PR updates the changes.md for the coming release.

I based the changes on the pull requests between 2.3.0 and now.
Please let me know if I missed anything.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #634 (9cda20e) into master (2811897) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9cda20e differs from pull request most recent head 96238c9. Consider uploading reports for the commit 96238c9 to get more accurate results

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   81.61%   81.59%   -0.02%     
==========================================
  Files         260      260              
  Lines       34680    34680              
==========================================
- Hits        28303    28297       -6     
- Misses       6377     6383       +6     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Now we support uncompressed bundle deployment so that multiple framework instances can share the same copy of bundle resources without decompressing bundle into their respective caches.

@PengZheng
Copy link
Contributor

Ugh. I committed CMake update to the wrong branch.

@pnoltes
Copy link
Contributor Author

pnoltes commented Sep 6, 2023

Ugh. I committed CMake update to the wrong branch.

Yeah I see, no worries if this and the Rust PoC is merged all is good.

@pnoltes
Copy link
Contributor Author

pnoltes commented Sep 6, 2023

LGTM

Now we support uncompressed bundle deployment so that multiple framework instances can share the same copy of bundle resources without decompressing bundle into their respective caches.

Yeah true. I also tried this out and this works. You can set the CELIX_AUTO_START_* using a dir path value and you can also apply a dir path value to add_celix_container.

CHANGES.md Outdated
- Support for Conan 2.
- Support for uclibc (not tested in CI yet).
- Support for C++14 in addition to C++17.
- Deprecated `snprintf` usage; transitioned to `snprintf` or `aprintf`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated snprintf usage; transitioned to snprintf

Copy/paste mistake of snprintf here (deprecated X, transitioned to X) ?

@pnoltes pnoltes merged commit e1d7fc1 into master Sep 15, 2023
22 checks passed
@pnoltes pnoltes deleted the feature/632-update-changes branch September 15, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants