-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/devcontainer #731
Open
pnoltes
wants to merge
37
commits into
master
Choose a base branch
from
feature/devcontainer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/devcontainer #731
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
eb38591
Add initial setup for devcontainer
pnoltes 74450e1
Fix trailing commas in devcontainer.json
pnoltes 9310ddc
Add devcontainer badge in README.md
pnoltes dc8afe8
Update .devcontainer/devcontainer.json
pnoltes b15249f
Merge branch 'refs/heads/master' into feature/devcontainer
pnoltes 6f45fb6
Refactor devcontainer setup for building with conan
pnoltes 3ceb3c5
Refactor Containerfile to build and dev with non root user
pnoltes 70922c9
Update devcontainer setup for gpg
pnoltes 247744a
Improve run container scripting and add initial readme
pnoltes d28280e
Combine container build ci with devcontainer setup
pnoltes 9dea26d
Fix apt container ci build configuration
pnoltes 8bc3f59
Update docker build command
pnoltes 8e5ff23
Move celixdev user to dev images
pnoltes de8b49a
Split container install, build & test in multiple steps
pnoltes ada1c88
Add conan.lock file to lock dependencies when using conan
pnoltes 8f678b5
Add conan cache action for ci container build using conan.lock
pnoltes e5a0640
Revert introduction conan.lock
pnoltes d2779cc
Update Containerfile and conan cache setup
pnoltes aa947f4
Add additional cache mechanisms for container ci builds
pnoltes fa845b9
Remove disallowed docker cache action
pnoltes e69a3e2
Update devcontainer to ubuntu 24.04 and fix openssl issue
pnoltes 6606e77
Replace usage of tags for github action to hashes
pnoltes d1ba2bf
Avoid the introduction of openssl dependency.
PengZheng d20f2b4
Remove openssl 1.1.1 override for Conan build on Ubuntu.
PengZheng a779cbf
Fix wrong conanrun.sh path.
PengZheng d4d41ce
Merge branch 'master' into feature/devcontainer
PengZheng 1e77207
Fix ctest warning.
PengZheng 14398f4
Fix ctest dynamic linking error.
PengZheng 52001cb
Fix conan option format.
PengZheng 50e1193
Update to macOS-12.
PengZheng d3b1e15
Enable address sanitizer in test_package.
PengZheng 95a34d8
Remove sudo in run_unit_test_discovery_zeroconf.
PengZheng 00dc17a
Fix test_package error.
PengZheng 2206733
Merge branch 'master' into feature/devcontainer
PengZheng ae2243a
Use sudo to start mdnsd in discovery_zeroconf unit test
xuzhenbao 02a82bf
Resolve unit test failed for discovery_zeroconf
xuzhenbao f9c22aa
Add securityOpts config for devcontainer.json
pnoltes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
If we need to start processes from C more often (e.g. etcd, msnd, etc) maybe we should also think about running integration test with help of something like behave or avocado. I think it is even possible to bootstrap behave/avocado from cmake/ctest using a
add_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll find some time to optimize the tests in another new PR.
I have tried to add FIXTURES in cmake yesterday, but due to some synchronization issues in the current unit tests, and I can't resolve them in a short time. so I'm going to start subprocess from C in this PR.