Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/conan private dep #735

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Hotfix/conan private dep #735

merged 10 commits into from
Mar 7, 2024

Conversation

PengZheng
Copy link
Contributor

@PengZheng PengZheng commented Mar 6, 2024

Fix linker error caused by private linking of transitive dependencies.
Check conan-io/conan#7192 for more information

Compared with previous workaround, this fix does not ignore unresolved symbols in shared libraries and thus is more robust.

I encountered a GitHub Action error which does not reproduce in my local machine: conan-io/conan#15818

Next time I will squash these debugging commits before merging them into trunk.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (0601f95) to head (acabf59).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   89.58%   89.63%   +0.05%     
==========================================
  Files         216      216              
  Lines       25413    25413              
==========================================
+ Hits        22765    22779      +14     
+ Misses       2648     2634      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PengZheng PengZheng merged commit d90acf5 into master Mar 7, 2024
32 checks passed
@PengZheng PengZheng deleted the hotfix/conan-private-dep branch March 7, 2024 00:39
@PengZheng PengZheng restored the hotfix/conan-private-dep branch March 7, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants