Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/Fix test_package error. #757

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

PengZheng
Copy link
Contributor

As observed, trying to scheduling event to an inactive framework will lead to test_package failure:

celix/3.0.0 (test package): RUN: ./use_components_ready_check

Hello world from C bundle with id 2
Bundle 1: apache_celix_components_ready_check
Bundle 2: hello
Goodbye world from C bundle with id 2
[2024-06-24T09:03:00] [   info] [celix_framework] [framework_start:483] Celix framework started

ERROR: celix/3.0.0 (test package): Error in test() method, line 149
	self.run("./use_components_ready_check",
	ConanException: Error 1 while executing

This PR fixes this by only issuing a warning instead of returning error.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (39e2282) to head (f82223d).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   90.26%   90.27%           
=======================================
  Files         226      226           
  Lines       26319    26320    +1     
=======================================
+ Hits        23758    23760    +2     
+ Misses       2561     2560    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PengZheng PengZheng merged commit 758aa79 into master Jun 24, 2024
32 checks passed
@PengZheng PengZheng deleted the hotfix/test-package-failure branch June 24, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants