Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special case for gp_toolkit when gprestore close cloudberry #681 #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yihong0618
Copy link

fix apache/cloudberry#681


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

There are two commits for this PR:

Contributor's checklist

Here are some reminders before you submit your pull request:

  • Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
  • Learn the code contribution and doc contribution guides for better collaboration.
  • List your communications in the GitHub Issues or Discussions (if has or needed).
  • Feel free to ask for the cloudberrydb team to help review and approve.

AJR-VMware and others added 2 commits November 4, 2024 11:32
Recent changes to gp_toolkit on GPDB7+ break restores if the gp_toolkit
schema was not already created.  Further we currently hard-fail if an
extension is meant to be in a schema that was not prior created.

To address the gp_toolkit issue and provide some additional stability,
explicitly add a CREATE IF NOT EXISTS statement for extension schemas.
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yihong0618
❌ AJR-VMware
You have signed the CLA already but the status is still pending? Let us recheck it.

@tuhaihe
Copy link
Member

tuhaihe commented Nov 4, 2024

Hi @yihong0618 thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] gprestore report : -ERROR: schema "gp_toolkit" does not exist (SQLSTATE 3F000)
4 participants