Updated invalid parameter/value error with proper exception

[sureshanaparti]

Description

This PR updates invalid parameter/value error with proper exception, to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException).

Fixes #9436

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 15.54%. Comparing base (d41dc17) to head (1af6b54).
Report is 65 commits behind head on main.

Files	Patch %	Lines
...loud/network/lb/LoadBalancingRulesManagerImpl.java	0.00%	13 Missing ⚠️
...udstack/storage/datastore/util/ElastistorUtil.java	0.00%	8 Missing ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	7 Missing ⚠️
...oud/hypervisor/vmware/mo/HypervisorHostHelper.java	0.00%	5 Missing ⚠️
.../main/java/com/cloud/network/NetworkModelImpl.java	0.00%	4 Missing ⚠️
...daylight/agent/OpenDaylightControllerResource.java	0.00%	2 Missing ⚠️
...oudstack/api/command/user/vm/GetVMPasswordCmd.java	0.00%	1 Missing ⚠️
...va/org/apache/cloudstack/kvm/ha/KVMHAProvider.java	0.00%	1 Missing ⚠️
.../org/apache/cloudstack/ha/SimulatorHAProvider.java	0.00%	1 Missing ⚠️
...kubernetes/cluster/CreateKubernetesClusterCmd.java	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9455     +/-   ##
===========================================
  Coverage     15.54%   15.54%             
+ Complexity    11977    11976      -1     
===========================================
  Files          5494     5494             
  Lines        481055   481056      +1     
  Branches      60787    58888   -1899     
===========================================
+ Hits          74771    74776      +5     
+ Misses       398022   398018      -4     
  Partials       8262     8262             

Flag	Coverage Δ
uitests	4.18% <ø> (ø)
unittests	16.31% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10484

[weizhouapache]

thanks @sureshanaparti
lgtm

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[FelipeM525]

LGTM!

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10552

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11058)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56728 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9455-t11058-kvm-ol8.zip
Smoke tests completed. 134 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	Error	427.70	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	Failure	450.80	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Failure	531.89	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	531.91	test_vpc_redundant.py
test_02_VPC_default_routes	Failure	198.48	test_vpc_router_nics.py

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10827

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11201)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51791 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9455-t11201-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	Failure	434.50	test_vpc_vpn.py

[sureshanaparti]

[SF] Trillian test result (tid-11201) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51791 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9455-t11201-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 434.50 test_vpc_vpn.py

failure not related to the changes here