Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of snapshot copy to StorPool primary storage in different zones #9478

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

fix snapshot deletion

457b33f
Select commit
Loading
Failed to load commit list.
Open

Support of snapshot copy to StorPool primary storage in different zones #9478

fix snapshot deletion
457b33f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 16, 2024 in 1s

4.60% of diff hit (target 15.81%)

View this Pull Request on Codecov

4.60% of diff hit (target 15.81%)

Annotations

Check warning on line 119 in api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java#L119

Added line #L119 was not covered by tests

Check warning on line 123 in api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java#L122-L123

Added lines #L122 - L123 were not covered by tests

Check warning on line 198 in api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java#L196-L198

Added lines #L196 - L198 were not covered by tests

Check warning on line 201 in api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java#L200-L201

Added lines #L200 - L201 were not covered by tests

Check warning on line 226 in api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java#L226

Added line #L226 was not covered by tests

Check warning on line 130 in api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java#L130

Added line #L130 was not covered by tests

Check warning on line 71 in api/src/main/java/org/apache/cloudstack/api/response/SnapshotPolicyResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/SnapshotPolicyResponse.java#L71

Added line #L71 was not covered by tests

Check warning on line 138 in api/src/main/java/org/apache/cloudstack/api/response/SnapshotPolicyResponse.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/src/main/java/org/apache/cloudstack/api/response/SnapshotPolicyResponse.java#L138

Added line #L138 was not covered by tests

Check warning on line 43 in engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreCapabilities.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreCapabilities.java#L43

Added line #L43 was not covered by tests

Check warning on line 47 in engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreCapabilities.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreCapabilities.java#L47

Added line #L47 was not covered by tests

Check warning on line 42 in engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java#L41-L42

Added lines #L41 - L42 were not covered by tests

Check warning on line 78 in engine/components-api/src/main/java/com/cloud/vm/VmWorkTakeVolumeSnapshot.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/components-api/src/main/java/com/cloud/vm/VmWorkTakeVolumeSnapshot.java#L76-L78

Added lines #L76 - L78 were not covered by tests

Check warning on line 562 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L562

Added line #L562 was not covered by tests

Check warning on line 565 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L564-L565

Added lines #L564 - L565 were not covered by tests

Check warning on line 569 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L567-L569

Added lines #L567 - L569 were not covered by tests

Check warning on line 572 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L572

Added line #L572 was not covered by tests

Check warning on line 576 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L576

Added line #L576 was not covered by tests

Check warning on line 60 in engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/ResourceDetailsDaoBase.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/ResourceDetailsDaoBase.java#L56-L60

Added lines #L56 - L60 were not covered by tests

Check warning on line 155 in engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java#L153-L155

Added lines #L153 - L155 were not covered by tests

Check warning on line 318 in engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java#L314-L318

Added lines #L314 - L318 were not covered by tests

Check warning on line 332 in engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java#L328-L332

Added lines #L328 - L332 were not covered by tests

Check warning on line 51 in engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java#L51

Added line #L51 was not covered by tests

Check warning on line 575 in engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java#L575

Added line #L575 was not covered by tests

Check warning on line 49 in engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/ScaleIOSnapshotStrategy.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/ScaleIOSnapshotStrategy.java#L49

Added line #L49 was not covered by tests

Check warning on line 786 in engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java#L785-L786

Added lines #L785 - L786 were not covered by tests