-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum details parameter to Search View's listDomains #9616
Add minimum details parameter to Search View's listDomains #9616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9616 +/- ##
============================================
- Coverage 15.57% 15.57% -0.01%
- Complexity 12037 12048 +11
============================================
Files 5501 5505 +4
Lines 482219 482621 +402
Branches 62044 60641 -1403
============================================
+ Hits 75125 75175 +50
- Misses 398791 399140 +349
- Partials 8303 8306 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I guess this should be done for other forms too
UI build: ✔️ |
most probably, but I think we can merge this (and create an issue for the rest or a discussion to do the inventarisation) |
Description
This PR adds the
details: min
parameter tolistDomains
API call. Since they are used only for ids and names, more details are unnecessary andlistDomains
ends up taking a long time to execute when many domains exist.In a test environment with 5000 domains, running
time cmk listDomains
yieldedcmk listDomains 0,31s user 0,11s system 1% cpu 31,200 total
, buttime cmk listDomains details=min
yieldedcmk listDomains details=min 0,14s user 0,04s system 7% cpu 2,521 total
.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
I set up an environment with 5000 domains and unlimited page size.
I then checked the Network tab on the browser before and after the changes (see Screenshots).
Searching itself worked normally.