[IO-856] test for background deletion

[thhart]

test for exceptional listing of deleted files

See IO-856

[garydgregory]

Hello @thhart

Thank you for your PR.

Please see my comments.

[garydgregory]

@thhart

Thank you for your update.

You did not apply my comments throughout. See my additional comments.

TY

[garydgregory]

@thhart

Please see my comments, same as before ;-)

[garydgregory]

Hello @thhart

Thank you for your update.

Interesting that the build on Java 24-ea is green.

Ubuntu shows:

FileUtilsListFilesTest.setUp:77 » FileSystem /tmp/junit-6966172520746092400/dummy-build.xml: Too many open files

Is that the point of the test?

Another builds show:

[INFO] There are 5 errors reported by Checkstyle 9.3 with D:\a\commons-io\commons-io/src/conf/checkstyle.xml ruleset.
Error:  src\test\java\org\apache\commons\io\FileUtilsListFilesTest.java:[27,1] (imports) ImportOrder: Wrong order for 'java.io.BufferedOutputStream' import.
Error:  src\test\java\org\apache\commons\io\FileUtilsListFilesTest.java:[41,1] (imports) ImportOrder: Wrong order for 'org.junit.jupiter.api.Assertions.assertEquals' import.
Error:  src\test\java\org\apache\commons\io\FileUtilsListFilesTest.java:[220,9] (whitespace) WhitespaceAfter: 'if' is not followed by whitespace.
Error:  src\test\java\org\apache\commons\io\FileUtilsListFilesTest.java:[245,18] (coding) FinalLocalVariable: Variable 'endTime' should be declared final.
Error:  src\test\java\org\apache\commons\io\FileUtilsListFilesTest.java:[261,18] (coding) FinalLocalVariable: Variable 'endTime' should be declared final.

Please run mvn by itself to run all build checks and fix errors before you push.

[thhart]

FileUtilsListFilesTest.setUp:77 » FileSystem /tmp/junit-6966172520746092400/dummy-build.xml: Too many open files

Is that the point of the test?

No, this is not failing in my environment. Maybe your Ubuntu is too restrictive in this.

[INFO] There are 5 errors reported by Checkstyle 9.3 with D:\a\commons-io\commons-io/src/conf/checkstyle.xml ruleset.

This is changed now.

Please run mvn by itself to run all build checks and fix errors before you push.

[ERROR] Errors: 
[ERROR]   FileUtilsListFilesTest.testListFilesWithDeletionThreaded:273 » Execution org.opentest4j.AssertionFailedError: this should not happen
[INFO] 
[ERROR] Tests run: 4246, Failures: 0, Errors: 1, Skipped: 24
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  05:18 min
[INFO] Finished at: 2024-11-08T09:09:46+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.1:test (default-test) on project commons-io: 
[ERROR] 
[ERROR] Please refer to /home/th/dev/os/commons-io/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

This fails in my Ubuntu system and in other Linux flavour. Can not say for other systems.

[garydgregory]

@thhart

Thank you for your updates. I'll take a look over the next couple of days.

[garydgregory]

Interesting: This is not reproducible on Windows in this CI for Java 8, 11, 17, 21, and 23.

[garydgregory]

Interesting meta-failure on Ubuntu:

[INFO] Running org.apache.commons.io.FileUtilsListFilesTest
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message can't create byte arrau at JPLISAgent.c line: 813
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message can't create byte arrau at JPLISAgent.c line: 813
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message can't create byte arrau at JPLISAgent.c line: 813
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message can't create byte arrau at JPLISAgent.c line: 813

[garydgregory]

Hello @thhart

• I added a slightly modified version of this test in FileUtilsListFilesTest.testListFilesWithDeletionThreaded()
• This test is only enabled on Windows
• There are hidden failures on GitHub CI on Ubuntu and macOS

[garydgregory]

@thhart

Please test git master. Closing this PR in favor or #699.

[thhart]

Looks ok now, have no problems any more.
(There was a wrong escape in the extension, it is not a pattern. I created a small patch for it.)