Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LANG-1702] Add test in TypeUtilsTest #1151

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 19, 2023

This passed locally so this bug might not be present any more, or perhaps it depends on JDK versions, or I don't understand it, or something. Let's see what the CI says and find out.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5e54fa) 92.08% compared to head (9fed76d) 92.11%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1151      +/-   ##
============================================
+ Coverage     92.08%   92.11%   +0.02%     
- Complexity     7584     7586       +2     
============================================
  Files           200      200              
  Lines         15825    15825              
  Branches       2890     2890              
============================================
+ Hits          14573    14577       +4     
+ Misses          677      674       -3     
+ Partials        575      574       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garydgregory
Copy link
Member

Hi @elharo
Run mvn locally to catch all build errors.

@elharo elharo changed the title test for LANG-1702 [LANG-1702] test for LANG-1702 Dec 23, 2023
@elharo elharo marked this pull request as ready for review December 23, 2023 01:46
@garydgregory garydgregory merged commit 959178e into apache:master Jan 3, 2024
15 checks passed
@garydgregory garydgregory changed the title [LANG-1702] test for LANG-1702 [LANG-1702] Add test in TypeUtilsTest Jan 3, 2024
asfgit pushed a commit that referenced this pull request Jan 3, 2024
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Jul 18, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `commons-lang3` from `3.14.0` to `3.15.0`

### Why are the changes needed?
- v3.14.0 VS v3.15.0
  apache/commons-lang@rel/commons-lang-3.14.0...rel/commons-lang-3.15.0

- The new version has brought some bug fixes, eg:
  apache/commons-lang#1140
  apache/commons-lang#1151

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #47396 from panbingkun/SPARK-48932.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `commons-lang3` from `3.14.0` to `3.15.0`

### Why are the changes needed?
- v3.14.0 VS v3.15.0
  apache/commons-lang@rel/commons-lang-3.14.0...rel/commons-lang-3.15.0

- The new version has brought some bug fixes, eg:
  apache/commons-lang#1140
  apache/commons-lang#1151

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47396 from panbingkun/SPARK-48932.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `commons-lang3` from `3.14.0` to `3.15.0`

### Why are the changes needed?
- v3.14.0 VS v3.15.0
  apache/commons-lang@rel/commons-lang-3.14.0...rel/commons-lang-3.15.0

- The new version has brought some bug fixes, eg:
  apache/commons-lang#1140
  apache/commons-lang#1151

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47396 from panbingkun/SPARK-48932.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants