Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cordova generates build.gradle with deprecated "compile" dependencies #485

Closed
jedrivisser opened this issue Aug 27, 2018 · 3 comments
Closed

Cordova generates build.gradle with deprecated "compile" dependencies #485

jedrivisser opened this issue Aug 27, 2018 · 3 comments
Labels
enhancement

Comments

@jedrivisser
Copy link
Contributor

When an android cordova plugin has a framework dependency, StudioBuilder.js generates a deprecated compile dependency instead of a implementation dependency:

https://github.com/apache/cordova-android/blob/7.1.x/bin/templates/cordova/lib/builders/StudioBuilder.js#L201
@janpio
Copy link
Member

janpio commented Aug 27, 2018 •
edited
Loading

This probably happens in multiple places.

Are you up to creating a PR for that to fix all of those? We would really appreciate it 💯

@jedrivisser
Copy link
Contributor Author

Will do

@jedrivisser jedrivisser mentioned this issue Aug 27, 2018
Merged
@jedrivisser
Copy link
Contributor Author

Changes are done

dpogue added a commit that referenced this issue Sep 26, 2018
@dpogue
Merge pull request #486 from jedrivisser/7.1.x
8dfddef 
GH-485: (android) Replace deprecated "compile" with "implementation"
@dpogue dpogue closed this as completed Sep 26, 2018
@ctfrancia ctfrancia mentioned this issue Aug 29, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janpio @dpogue @jedrivisser