Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allprojects repositories to Framework Build Gradle #676

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 18, 2019

Platforms affected

android

Motivation and Context

To be able to release the Cordova Android Framework to JFrog Bintray.

Description

Was not able to release the framework to Bintray because of build failures.

Starting a Gradle Daemon, 1 stopped Daemon could not be reused, use --status for details
> Task :packageReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all files for configuration ':_internal_aapt2_binary'.
> Could not find com.android.tools.build:aapt2:3.3.0-5013011.
  Searched in the following locations:
    - file:/Android/sdk/extras/m2repository/com/android/tools/build/aapt2/3.3.0-5013011/aapt2-3.3.0-5013011.pom
    - file:/Android/sdk/extras/m2repository/com/android/tools/build/aapt2/3.3.0-5013011/aapt2-3.3.0-5013011-osx.jar
    - file:/Android/sdk/extras/google/m2repository/com/android/tools/build/aapt2/3.3.0-5013011/aapt2-3.3.0-5013011.pom
    - file:/Android/sdk/extras/google/m2repository/com/android/tools/build/aapt2/3.3.0-5013011/aapt2-3.3.0-5013011-osx.jar
    - file:/Android/sdk/extras/android/m2repository/com/android/tools/build/aapt2/3.3.0-5013011/aapt2-3.3.0-5013011.pom
    - file:/Android/sdk/extras/android/m2repository/com/android/tools/build/aapt2/3.3.0-5013011/aapt2-3.3.0-5013011-osx.jar
  Required by:
      project :

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 55s
5 actionable tasks: 5 executed

This issue was fixed by adding to the cordova-android/framework/build.gradle file:

allprojects {
    repositories {
        google()
        jcenter()
    }
}

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from dpogue February 18, 2019 00:33
@codecov-io
Copy link

Codecov Report

Merging #676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #676   +/-   ##
======================================
  Coverage    64.4%   64.4%           
======================================
  Files          18      18           
  Lines        1826    1826           
======================================
  Hits         1176    1176           
  Misses        650     650

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e390a...17b7e32. Read the comment docs.

@erisu erisu added this to the 8.0.1 milestone Apr 5, 2019
@erisu erisu merged commit b177f84 into apache:master Apr 6, 2019
@erisu erisu deleted the fix-framework-release-build branch April 6, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants