Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordova-node-xcode@2.1.0 release notes #1037

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Dec 13, 2019

Platforms affected

iOS, osx (macOS)

Motivation and Context

release notes needed for upcoming xcode@2.1.0 release

Description

release notes for upcoming xcode@2.1.0 release, with external contributions

  • Support watch2 apps/extensions (#56)
  • Update writeObjectsSections to match current Xcode format (#46)

Testing

quick visual inspection

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@brodycj brodycj marked this pull request as ready for review December 24, 2019 19:38
Copy link
Contributor

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok.

Also, I was wondering what do you mean by external contributions? If you mean non-Apache members there are quite a lot of those changes in our repos and not sure if it is necessary to say as it is a given is oss.

But either way it is ok!

@brodycj brodycj merged commit 4cacdda into apache:master Dec 24, 2019
@brodycj brodycj deleted the xcode-release-2.1.0 branch December 24, 2019 21:30
@brodycj
Copy link
Contributor Author

brodycj commented Dec 24, 2019

Thanks guys for the quick review.

The one thing is that this release was mostly triggered by non-Cordova members. But yeah, probably not needed to state this:)

@erisu
Copy link
Member

erisu commented Dec 24, 2019

Ah OK, I understand, thanks for the clarification.

Thank you for tackling this release! As well to all the external contributors who put in the work behind this release! 🎉

@brodycj
Copy link
Contributor Author

brodycj commented Dec 25, 2019

@erisu I just saw your private message on Slack, would appreciate it if you can help with the manual build. (I don't even know how to do it.) Thanks again!

@erisu
Copy link
Member

erisu commented Dec 25, 2019

The blog post is now released and available on the website at:

https://cordova.apache.org/news/2019/12/24/xcode-release-2.1.0.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants