-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cordova-node-xcode@2.1.0 release notes #1037
Conversation
6ea0769
to
0b9b620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks ok.
Also, I was wondering what do you mean by external contributions? If you mean non-Apache members there are quite a lot of those changes in our repos and not sure if it is necessary to say as it is a given is oss.
But either way it is ok!
Thanks guys for the quick review. The one thing is that this release was mostly triggered by non-Cordova members. But yeah, probably not needed to state this:) |
Ah OK, I understand, thanks for the clarification. Thank you for tackling this release! As well to all the external contributors who put in the work behind this release! 🎉 |
@erisu I just saw your private message on Slack, would appreciate it if you can help with the manual build. (I don't even know how to do it.) Thanks again! |
The blog post is now released and available on the website at: https://cordova.apache.org/news/2019/12/24/xcode-release-2.1.0.html |
Platforms affected
iOS, osx (macOS)
Motivation and Context
release notes needed for upcoming xcode@2.1.0 release
Description
release notes for upcoming xcode@2.1.0 release, with external contributions
Testing
quick visual inspection
Checklist
I added automated test coverage as appropriate for this changeCommit is prefixed with(platform)
if this change only applies to one platform (e.g.(android)
)If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)