[CB-14145 WIP] patch update to resolve npm audit warnings - WIP PENDING upstream patches #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 22, 2018 07:10
from cordova.js@4.2.4
remove packages no longer needed: - coffee-script (old package name, was deprecated in favor of coffeescript) - uncrustify
- xxx/cordova-common#xxx - xxx/ios-sim#xxx - plist@^2.1.0
|
Closing in favor of #379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
TBD this proposed update is WIP pending patches to multiple dependencies as proposed by @brodybits.
Proposed changes to
4.5.xbranch for patch update:4.5.5-devnpm auditwarnings without causing engine warning on node 4:brodybits/cordova-common#plist-2-patchas proposed in [CB-14174, CB-14145] package.json use plist@2 to resolve engine warning on node 4 in 2.2.x patch release cordova-common#31brodybits/ios-sim#plist-2-patchas proposed in plist@2 patch ios-control/ios-sim#233plist@^2.1.0WIP TODO items:
cordova-commonupdate with [CB-14174, CB-14145] package.json use plist@2 to resolve engine warning on node 4 in 2.2.x patch release cordova-common#31 fix from npmios-simupdate with plist@2 patch ios-control/ios-sim#233 fix from npmWhat testing has been done on this change?
npm installon node 4 does not generate any engine warning messagesnpm run unit-testspassing (on node 4)npm auditshows no warnings onnpm@6.1.0TEST TODO items:
npm teststages pass on Travis CIcordova platform add brodybits/cordova-ios#cb-14145-patch-updateon new Cordova project and verify that it runs on iOScordova platform add brodybits/cordova-ios#cb-14145-patch-updateon cordova-sqlite-storage test suite (cordova-sqlite-specproject) and verify that it succeeds on iOS (emulator or device)Checklist
Added automated test coverage as appropriate for this change.