Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check for missing pathname #539 #571

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Null check for missing pathname #539 #571

merged 2 commits into from
Mar 15, 2019

Conversation

purplecabbage
Copy link
Contributor

This is causing a crash if someone whitelists just a protocol, ex file://
See #539

Platforms affected

iOS

Description

Reviewed the code, and made the change.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

This is causing a crash if someone whitelists just a protocol, ex `file://`
See #539
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I love how a little whitespace can bring the whole universe crashing to a halt.
@codecov-io
Copy link

Codecov Report

Merging #571 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage    74.6%   74.57%   -0.03%     
==========================================
  Files          11       11              
  Lines        1823     1825       +2     
==========================================
+ Hits         1360     1361       +1     
- Misses        463      464       +1
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 83.66% <66.66%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d59304...5f003f9. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #571 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage    74.6%   74.57%   -0.03%     
==========================================
  Files          11       11              
  Lines        1823     1825       +2     
==========================================
+ Hits         1360     1361       +1     
- Misses        463      464       +1
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 83.66% <66.66%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d59304...5f003f9. Read the comment docs.

@dpogue dpogue added this to the 5.0.1 milestone Mar 15, 2019
@dpogue dpogue merged commit e4304be into master Mar 15, 2019
@dpogue dpogue deleted the purplecabbage-patch-1 branch March 15, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants